Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mahjong and Dou Dizhu performance #91

Open
lssr opened this issue Mar 22, 2020 · 9 comments
Open

Mahjong and Dou Dizhu performance #91

lssr opened this issue Mar 22, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@lssr
Copy link

lssr commented Mar 22, 2020

After running some performance tests will all the games (see results below), @justinkterry and I noticed that Mahjong and Dou Dizhu are considerably slower than the rest of the games. Is there any reason for this?

Game Turns/Actions per second
Mahjong 970
Dou Dizhu 6668
Uno 18349
Leduc Holdem 29447
Texas Holdem 20092
Texas Holdem no limit 15699
@daochenzha
Copy link
Member

@lssr Thanks for these results. They are really helpful. These games are slow mainly due to their complex game logics. Because these two games need continuous checking of hand. Thus, we can not expect these two games have comparable speed as Texas Hold’em.

For Dou Dizhu, the performance should be near optimal. For example, we have replaced some time-consuming parts with pre-defined maps. It is much faster than the first version. I believe to further improve the speed of Dou Dizhu, the only choice is to reimplemented it with C/C++.

For Mahjong, the performance is not optimized. Thus, there should be much space to improve the speed.

@jkterry1
Copy link
Contributor

Is further Mahjong optimization planned?

@daochenzha
Copy link
Member

Yes, it is planned.

@daochenzha daochenzha added the enhancement New feature or request label Mar 31, 2020
@jkterry1
Copy link
Contributor

Any movement on mahjong optimizations?

@daochenzha
Copy link
Member

@justinkterry Thanks for asking. We do find some redundant logics that can be simplified. We are still working on it.

@jkterry1
Copy link
Contributor

@daochenzha any news on mahjong optimizations?

@daochenzha
Copy link
Member

@justinkterry Not yet. We will busy with some other deadlines recently. We will work on it later.

@jkterry1
Copy link
Contributor

@daochenzha anything new for mahjong?

@jkterry1
Copy link
Contributor

jkterry1 commented Dec 9, 2020

@daochenzha Just following up on Mahjong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants