Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuhn poker implementation #171

Open
cfytrok opened this issue Sep 30, 2020 · 1 comment
Open

Kuhn poker implementation #171

cfytrok opened this issue Sep 30, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@cfytrok
Copy link

cfytrok commented Sep 30, 2020

I want to implement Kuhn poker and create pull request.
The documentation says that I have to inherit from classes in rlcard/core.py.
However, Leduc poker is implemented by inheriting from limit poker classes. It looks like the limit poker classes are the base class for other games.
I want to implement kuhn poker for an arbitrary number of players, but it seems the limit poker implementation only supports 2 players.
How to do it better?

@daochenzha
Copy link
Member

@cfytrok I think both will work. We implemented Leduc poker by inheriting from limit poker classes because those pokers have similar rules. Inheriting limit poker classes saves efforts.

@daochenzha daochenzha added the help wanted Extra attention is needed label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants