Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #230

Closed
phgrosjean opened this issue May 23, 2024 · 2 comments
Closed

GitHub actions #230

phgrosjean opened this issue May 23, 2024 · 2 comments

Comments

@phgrosjean
Copy link
Collaborator

I am cleaning up the GitHub actions for this repository. Done so far:

  • Eliminated the lint action (can be done at the command line or from RStudio admin easily, if needed, and not vital)
  • Updated R-CMD-check, pr-commands and test-coverage
  • Attempted to get pkgdown succeeding

I struggle with the covrpage section in the pkgdown action, and more particularly with {git2r} that seems incorrectly installed. If I understand it well, this section updates the test covering report in the pkgdown web site, is this correct? The "codecov" badge on the README page already gives access to a detailed and interactive report of the same data. Also, this seems to be more "technical" information that most end-users do not need. I feel that the coverage report page in the "articles" section of the website should not be there. Would it make sense to just delete this covrpage section in the pkgdown action?

One more stuff: what is the reason for recompiling from sources {Matrix} and {lme4} in the R-CMD-check and pr-commands actions? Is it still needed? These GitHub actions take much longer than they should if this is not required (any more).

@datalorax
Copy link
Owner

The recompiling one related to some mixed versions or something along those lines a while back that was causing the whole thing to fail. Installing from source was the only way I could figure out to fix it. Totally fine to change if you want.

I'm also totally fine deleting the covrpage section. That was put in by a PR from a collaborator and I was never super sold on it but he had contributed other meaningful pieces and felt strongly about it so I went with it.

@phgrosjean
Copy link
Collaborator Author

OK, thanks. I will simplify GitHub actions by eliminating those two items (covrpage from pkgdown and compilation form source for two packages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants