From f2f412bf59edbb6e58499520d6197b318244e848 Mon Sep 17 00:00:00 2001 From: Christian Tabedzki <35670232+tabedzki@users.noreply.github.com> Date: Thu, 5 Sep 2024 18:07:40 -0400 Subject: [PATCH 1/3] Added encapsulating double quotes to comply with DOT language --- datajoint/diagram.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datajoint/diagram.py b/datajoint/diagram.py index 65497fcf..0d35a98b 100644 --- a/datajoint/diagram.py +++ b/datajoint/diagram.py @@ -289,7 +289,7 @@ def _make_graph(self): ) # relabel nodes to class names mapping = { - node: lookup_class_name(node, self.context) or node + node: f'"{lookup_class_name(node, self.context) or node}"' for node in graph.nodes() } new_names = [mapping.values()] From 393edfcff2d17a281c2842ec92e29ed82dcfbaf4 Mon Sep 17 00:00:00 2001 From: Christian Tabedzki <35670232+tabedzki@users.noreply.github.com> Date: Fri, 6 Sep 2024 09:22:15 -0400 Subject: [PATCH 2/3] Updated changelog.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f05e514e..27c9159f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ ## Release notes +### Upcoming +- Fixed - Added encapsulating double quotes to comply with [DOT language](https://graphviz.org/doc/info/lang.html) - PR [#1176](https://github.com/datajoint/datajoint-python/pull/1176) + ### 0.14.2 -- Aug 19, 2024 - Added - Migrate nosetests to pytest - PR [#1142](https://github.com/datajoint/datajoint-python/pull/1142) - Added - Codespell GitHub Actions workflow From b238a4c18517d38182459acef958fbf52eac2d28 Mon Sep 17 00:00:00 2001 From: Christian Tabedzki <35670232+tabedzki@users.noreply.github.com> Date: Fri, 6 Sep 2024 16:03:52 -0400 Subject: [PATCH 3/3] Warpping things in double quotes --- tests_old/test_erd.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests_old/test_erd.py b/tests_old/test_erd.py index 1a629343..a27b6463 100644 --- a/tests_old/test_erd.py +++ b/tests_old/test_erd.py @@ -83,5 +83,5 @@ def test_part_table_parsing(): # https://github.com/datajoint/datajoint-python/issues/882 erd = dj.Di(schema) graph = erd._make_graph() - assert "OutfitLaunch" in graph.nodes() - assert "OutfitLaunch.OutfitPiece" in graph.nodes() + assert '"OutfitLaunch"' in graph.nodes() + assert '"OutfitLaunch.OutfitPiece"' in graph.nodes()