Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Equipment naming collisions - anticipated issue #83

Closed
CBroz1 opened this issue Apr 15, 2022 · 3 comments
Closed

Equipment naming collisions - anticipated issue #83

CBroz1 opened this issue Apr 15, 2022 · 3 comments
Assignees
Labels
standardization To be implemented across all elements
Milestone

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Apr 15, 2022

Across a number of element workflows, we specify an equipment or device table in the pipeline.

Currently, I think facemap and deeplabcut can be used simultaneously, but I propose we adopt a naming convention within workflows so that all elements work together smoothly out of the box (e.g., FacemapEquipment, DeepLabCutEquipment). A user could collapse these tables

@CBroz1
Copy link
Contributor Author

CBroz1 commented Apr 27, 2022

The team discussed changing this table to Device to minimize disruptions to existing pipelines

  • workflow-calcium-imaging
  • workflow-deeplabcut
  • workflow-facemap
  • workflow-miniscope
@lab.schema
class Device(dj.Manual):
    definition = """
    device.                 : varchar(32)
    ---
    modality               : varchar(64)
    description=null  : varchar(256)
    """

@CBroz1 CBroz1 self-assigned this Apr 27, 2022
@CBroz1 CBroz1 added this to the NIH U24 Year 3 milestone Apr 27, 2022
@CBroz1 CBroz1 added the standardization To be implemented across all elements label May 5, 2022
@CBroz1 CBroz1 modified the milestones: 2022Q1, Year 2 May 6, 2022
@CBroz1 CBroz1 modified the milestones: Year 2, 2022Q2 May 10, 2022
@CBroz1 CBroz1 modified the milestones: 2022Q2, 2022Q3 May 20, 2022
@CBroz1
Copy link
Contributor Author

CBroz1 commented Jun 8, 2022

Updated above to reflect discussion

@CBroz1
Copy link
Contributor Author

CBroz1 commented Jun 8, 2022

In discussion between @ttngu207 and @kabilar, the team decided not to standardize workflow-level namespaces

@CBroz1 CBroz1 closed this as completed Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
standardization To be implemented across all elements
Projects
None yet
Development

No branches or pull requests

1 participant