fix: read entire file with ArrowReader #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Nov 5, 2023
Comment on lines
+120
to
+126
| Some(stripe) => { | ||
| match stripe | ||
| .next() | ||
| .map(|batch| batch.map_err(|err| ArrowError::ExternalError(Box::new(err)))) | ||
| { | ||
| Some(rb) => Some(rb), | ||
| None => self.try_advance_stripe(), |
There was a problem hiding this comment.
Bug was here as after stripe returned None, iterator would not advance any further
WenyXu
approved these changes
Nov 5, 2023
progval
pushed a commit
to progval/datafusion-orc
that referenced
this pull request
Mar 6, 2024
Allow to convert the internal error to anyhow::Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously wasn't able to read past first stripe in ArrowReader, fix to allow