Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable DataFusion as a default feature #124

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Disable DataFusion as a default feature #124

merged 5 commits into from
Sep 20, 2024

Conversation

Jefffrey
Copy link
Collaborator

Datafusion has a large dependency footprint, so make it opt-in

Xuanwo
Xuanwo reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Part of CI failed for this change, maybe we need to tune our CI settings too.

@Jefffrey
Copy link
Collaborator Author

Thanks! Part of CI failed for this change, maybe we need to tune our CI settings too.

Should be fixed now 👍

@WenyXu WenyXu merged commit 6c513b3 into main Sep 20, 2024
11 checks passed
@WenyXu WenyXu deleted the remove-df-from-default branch September 20, 2024 16:20
@Xuanwo
Copy link
Collaborator

Xuanwo commented Sep 20, 2024

Great, thanks for @Jefffrey's work and @WenyXu's review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

@WenyXu WenyXu WenyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jefffrey @Xuanwo @WenyXu