Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completeness of implementation? #11

Open
adriangb opened this issue Jan 2, 2025 · 1 comment
Open

completeness of implementation? #11

adriangb opened this issue Jan 2, 2025 · 1 comment

Comments

@adriangb
Copy link

adriangb commented Jan 2, 2025

hi @suremarc, I was wondering if the implementation here is complete? I was trying to grok it and came across e.g. https://github.com/datafusion-contrib/datafusion-materialized-views/blob/main/src/rewrite.rs which seems to be an empty file. I wanted to confirm what the state of the repo is before I break my brain. Thanks for your work on this!

@suremarc
Copy link
Collaborator

suremarc commented Jan 2, 2025

Hey @adriangb, so far the materialized module is pretty much complete, which is the piece related to incrementally maintaining materialized views. The rewrite module is for "query rewriting" which is more about exploiting materialized views to speed up queries. Everything in the materialized module is nearly ready, I'm cooking up an integration test which should serve dually as an example of how to use it, but I'm still ironing out some small bugs.

After finishing up the integration test I plan to port the query rewriting code to that empty file you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants