Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new option for Built-in assertions name #1899

Open
hkak03key opened this issue Jan 26, 2025 · 0 comments
Open

add new option for Built-in assertions name #1899

hkak03key opened this issue Jan 26, 2025 · 0 comments

Comments

@hkak03key
Copy link

hkak03key commented Jan 26, 2025

Background

We set defaultAssertionDataset same as defaultDataset

I am considering setting the destination for views generated by assertions to the same location as the models.
(In other words, I plan to set defaultDataset and defaultAssertionDataset to the same value.)
This is because, when defaultDataset is shared across multiple repositories, views generated by assertions may end up with duplicate or conflicting names between repositories.

Our model naming rule

For model naming, I use the following convention:

  • Outputs models: No prefix.
  • Intermediate models: Prefix _.
  • Source models: Prefix __.
    (This is somewhat similar to Python conventions.)
    I adopted this approach because prefixes like stg_ or intermediate_ might not be intuitive for non-engineer analysts who come from a marketing background.

Problem

Built-in assertions generate views with the naming convention:
"${ACTION_DATASET_NAME}_${ACTION_NAME}_assertions_${BUILD_IN_ASSERTION}".
This naming pattern conflicts with the convention used for outputs models.

Solution

Introduce an additional option called buildinAssertionPrefix.


Of course, one alternative would be to create a separate defaultAssertionDataset for each repository.
However, this approach would significantly increase the number of resources, which I find less desirable.

I would appreciate it if you could kindly consider this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant