-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document decision on testing strategy #13
Comments
@jgaehring as discussed in our meeting today, I will leave it to you to update here with a couple of sentences what was decided for the testing strategy of the Type script connector and close the issue. Many thanks! |
The decision was to go ahead with using code generation for the TS tests, once datafoodconsortium/connector-codegen#20 is merged or possibly before, depending upon when and how work on that resumes. Currently, all of the tests in Before coming to that decision, I had raised the concern whether or not generating the tests themselves was considered a best practice, since it could theoretically introduce regressions or other bugs if errors in how the library implementation was generated were essentially duplicated in the generation of the tests. I don't recall the specific reasons, unfortunately (b/c I waited so long to write this up, argh! 🤦🏻), but @lecoqlibre provided sufficient rationale for why this would not be a problem. I believe this is sufficient to close this now, @RachL, though I don't appear to have permissions to do so. |
No description provided.
The text was updated successfully, but these errors were encountered: