Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document decision on testing strategy #13

Closed
RachL opened this issue Apr 22, 2024 · 2 comments
Closed

Document decision on testing strategy #13

RachL opened this issue Apr 22, 2024 · 2 comments
Assignees

Comments

@RachL
Copy link
Member

RachL commented Apr 22, 2024

No description provided.

@RachL RachL moved this from Icebox ❄ to Todo in Tech meeting board Apr 22, 2024
@RachL
Copy link
Member Author

RachL commented Jul 1, 2024

@jgaehring as discussed in our meeting today, I will leave it to you to update here with a couple of sentences what was decided for the testing strategy of the Type script connector and close the issue. Many thanks!

@jgaehring
Copy link

The decision was to go ahead with using code generation for the TS tests, once datafoodconsortium/connector-codegen#20 is merged or possibly before, depending upon when and how work on that resumes.

Currently, all of the tests in connector-codegen-typescript have been hardcoded and are copied along with the other static modules. This is retained so far in datafoodconsortium/connector-codegen#20. However, there is an established pattern for generating tests in PHP that could be adapted to the TypeScript scenario, which is what we've decided to do here.

Before coming to that decision, I had raised the concern whether or not generating the tests themselves was considered a best practice, since it could theoretically introduce regressions or other bugs if errors in how the library implementation was generated were essentially duplicated in the generation of the tests. I don't recall the specific reasons, unfortunately (b/c I waited so long to write this up, argh! 🤦🏻), but @lecoqlibre provided sufficient rationale for why this would not be a problem.

I believe this is sufficient to close this now, @RachL, though I don't appear to have permissions to do so.

@RachL RachL closed this as completed Sep 24, 2024
@github-project-automation github-project-automation bot moved this from To review ☕ to Done in Tech meeting board Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants