@ in password not support

[qsliu2017]

Describe the bug

Say a user with password passwd@123. Since @ in DSN can not be distinguished, it should be quoted as passwd%40123. However datadiff does not support quoted DSN currently.

After searching, I found that dsnparse 0.2.0 has support that kind of quoted DSNs.

please consider to upgrade the dependency version to “>0.2.0”.

data-diff/pyproject.toml

Line 28 in be5256c

dsnparse = "<0.2.0"

[dlawin]

@qsliu2017 ty for reporting this!

There was an issue in 0.2.0 here #616

We'll have to investigate/mitigate that if we bump the version up

[sungchun12]

@qsliu2017 What databases are you diffing? We recently fixed this for postgres: #812

[qsliu2017]

@qsliu2017 What databases are you diffing? We recently fixed this for postgres: #812

oracle :(

[sungchun12]

Okay, I think this should be relatively easy to fix.

[DiogoParrinhaAM]

Same issue here

[DiogoParrinhaAM]

Workaround: use a job file

[glebmezh]

Hi @qsliu2017 and @DiogoParrinhaAM,

I'm sorry for the delay in following up on this. Thank you for raising this issue and for looking into potential solutions!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that's of interest, over the past few months, we have rewritten the diffing engine in Datafold Cloud and solved many issues that existed in this package's diffing algorithm. Feel free to take it for a trial and contact us at [email protected] if you have any questions.

-Gleb