From b4e2d4b626e31afafe9d1b5e33759f991e05b27b Mon Sep 17 00:00:00 2001 From: Leo Folsom Date: Tue, 12 Mar 2024 16:12:09 -0700 Subject: [PATCH] Update README.md (#876) * Update README.md Remove databases that are not planned from README. * style fixes by ruff --------- Co-authored-by: leoebfolsom --- README.md | 7 ------- data_diff/cloud/data_source.py | 9 +++------ data_diff/diff_tables.py | 7 +++---- data_diff/joindiff_tables.py | 3 +-- data_diff/queries/extras.py | 1 + data_diff/utils.py | 4 +--- 6 files changed, 9 insertions(+), 22 deletions(-) diff --git a/README.md b/README.md index 82dff770..5da51054 100644 --- a/README.md +++ b/README.md @@ -170,18 +170,11 @@ Check out [documentation](https://docs.datafold.com/reference/open_source/cli) f | Trino | 🟡 | `trino://:@:8080/` | | Clickhouse | 🟡 | `clickhouse://:@:9000/` | | Vertica | 🟡 | `vertica://:@:5433/` | -| ElasticSearch | 📝 | | -| Planetscale | 📝 | | -| Pinot | 📝 | | -| Druid | 📝 | | | -| SQLite | 📝 | | *MS SQL Server support is limited, with known performance issues that are addressed in Datafold Cloud. * 🟢: Implemented and thoroughly tested. * 🟡: Implemented, but not thoroughly tested yet. -* ⏳: Implementation in progress. -* 📝: Implementation planned. Contributions welcome. Your database not listed here? diff --git a/data_diff/cloud/data_source.py b/data_diff/cloud/data_source.py index 3f3b2e16..5bab4985 100644 --- a/data_diff/cloud/data_source.py +++ b/data_diff/cloud/data_source.py @@ -90,18 +90,15 @@ def create_ds_config( @overload -def _cast_value(value: str, type_: Literal["integer"]) -> int: - ... +def _cast_value(value: str, type_: Literal["integer"]) -> int: ... @overload -def _cast_value(value: str, type_: Literal["boolean"]) -> bool: - ... +def _cast_value(value: str, type_: Literal["boolean"]) -> bool: ... @overload -def _cast_value(value: str, type_: Literal["string"]) -> str: - ... +def _cast_value(value: str, type_: Literal["string"]) -> str: ... def _cast_value(value: str, type_: str) -> Union[bool, int, str]: diff --git a/data_diff/diff_tables.py b/data_diff/diff_tables.py index 31a01a07..4fc581f2 100644 --- a/data_diff/diff_tables.py +++ b/data_diff/diff_tables.py @@ -1,5 +1,5 @@ -"""Provides classes for performing a table diff -""" +"""Provides classes for performing a table diff""" + import threading import time from abc import ABC, abstractmethod @@ -284,8 +284,7 @@ def _diff_segments( level=0, segment_index=None, segment_count=None, - ): - ... + ): ... def _bisect_and_diff_tables(self, table1: TableSegment, table2: TableSegment, info_tree): if len(table1.key_columns) != len(table2.key_columns): diff --git a/data_diff/joindiff_tables.py b/data_diff/joindiff_tables.py index 2d5e631a..2a0a4023 100644 --- a/data_diff/joindiff_tables.py +++ b/data_diff/joindiff_tables.py @@ -1,6 +1,5 @@ -"""Provides classes for performing a table diff using JOIN +"""Provides classes for performing a table diff using JOIN""" -""" from decimal import Decimal from functools import partial import logging diff --git a/data_diff/queries/extras.py b/data_diff/queries/extras.py index 7d67ae97..a8098c7a 100644 --- a/data_diff/queries/extras.py +++ b/data_diff/queries/extras.py @@ -1,4 +1,5 @@ "Useful AST classes that don't quite fall within the scope of regular SQL" + from typing import Callable, Optional, Sequence import attrs diff --git a/data_diff/utils.py b/data_diff/utils.py index 8c8e2715..1d1405fd 100644 --- a/data_diff/utils.py +++ b/data_diff/utils.py @@ -72,8 +72,7 @@ def match_regexps(regexps: Dict[str, Any], s: str) -> Sequence[tuple]: class CaseAwareMapping(MutableMapping[str, V]): @abstractmethod - def get_key(self, key: str) -> str: - ... + def get_key(self, key: str) -> str: ... def new(self, initial=()) -> Self: return type(self)(initial) @@ -416,7 +415,6 @@ def get_from_dict_with_raise(dictionary: Dict, key: str, exception: Exception): class Vector(tuple): - """Immutable implementation of a regular vector over any arithmetic value Implements a product order - https://en.wikipedia.org/wiki/Product_order