From 792c78e21c4fbc39ebd2fdfec9bd8ead86da6ed8 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:10:13 -0300 Subject: [PATCH 01/11] DCV-2609 add test cases for dbt 1.6/7/8 --- Makefile | 43 ++++++++++++++++++++++++++++++++++++++++++- pyproject.toml | 2 +- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a7c3caf..b144154 100644 --- a/Makefile +++ b/Makefile @@ -54,6 +54,35 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt15/bin/pip install "dbt-core>=1.5.0,<1.6.0"; \ done +.venv-dbt16/bin/python: + python -m venv .venv-dbt16 + .venv-dbt16/bin/pip install --upgrade wheel setuptools pip + .venv-dbt16/bin/pip install pytest WebTest . + for adapter in $(ADAPTERS); do \ + .venv-dbt16/bin/pip install "dbt-$$adapter>=1.5.0,<1.7.0"; \ + .venv-dbt16/bin/pip install "dbt-core>=1.6.0,<1.7.0"; \ + done + +.venv-dbt17/bin/python: + python -m venv .venv-dbt17 + .venv-dbt17/bin/pip install --upgrade wheel setuptools pip + .venv-dbt17/bin/pip install pytest WebTest . + for adapter in $(ADAPTERS); do \ + .venv-dbt17/bin/pip install "dbt-$$adapter>=1.6.0,<1.8.0"; \ + .venv-dbt17/bin/pip install "dbt-core>=1.7.0,<1.8.0"; \ + done + +.venv-dbt18/bin/python: + python -m venv .venv-dbt18 + .venv-dbt18/bin/pip install --upgrade wheel setuptools pip + .venv-dbt18/bin/pip install pytest WebTest . + for adapter in $(ADAPTERS); do \ + .venv-dbt18/bin/pip install "dbt-$$adapter>=1.7.0,<1.9.0"; \ + .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ + .venv-dbt18/bin/pip install "dbt-adapters~=1.2.0; \ + .venv-dbt18/bin/pip install "dbt-common~=1.2.0; \ + done + clean: rm -rf .venv-dbt10 .venv-dbt11 .venv-dbt12 .venv-dbt13 .venv-dbt14 .venv-dbt15 .PHONY: clean @@ -82,5 +111,17 @@ test-dbt1.5: .venv-dbt15/bin/python .venv-dbt15/bin/python -m pytest tests/test_main.py .PHONY: test-dbt1.5 -test: test-dbt1.0 test-dbt1.1 test-dbt1.2 test-dbt1.3 test-dbt1.4 test-dbt1.5 +test-dbt1.6: .venv-dbt16/bin/python + .venv-dbt16/bin/python -m pytest tests/test_main.py +.PHONY: test-dbt1.6 + +test-dbt1.7: .venv-dbt17/bin/python + .venv-dbt17/bin/python -m pytest tests/test_main.py +.PHONY: test-dbt1.7 + +test-dbt1.8: .venv-dbt18/bin/python + .venv-dbt18/bin/python -m pytest tests/test_main.py +.PHONY: test-dbt1.8 + +test: test-dbt1.0 test-dbt1.1 test-dbt1.2 test-dbt1.3 test-dbt1.4 test-dbt1.5 test-dbt1.6 test-dbt1.7 test-dbt1.8 .PHONY: test diff --git a/pyproject.toml b/pyproject.toml index 38d52bc..e614fc8 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -14,7 +14,7 @@ classifiers = ["Development Status :: 3 - Alpha"] Changelog = "https://github.com/z3z1ma/dbt-core-interface/releases" [tool.poetry.dependencies] -python = ">=3.8,<3.12" +python = ">=3.8,<3.13" [tool.poetry.dev-dependencies] Pygments = ">=2.10.0" From 0422210791ae519d6e59d5b52355bd2a7bd14e87 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:16:50 -0300 Subject: [PATCH 02/11] Implement new tests --- .github/workflows/tests.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ece6e65..17a6d16 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,6 +16,9 @@ jobs: # Latest dbts' test matrix on 3.11 (well supported py version) on ubuntu - { python: "3.11", os: "ubuntu-latest", dbt: "1.4" } - { python: "3.11", os: "ubuntu-latest", dbt: "1.5" } + - { python: "3.11", os: "ubuntu-latest", dbt: "1.6" } + - { python: "3.11", os: "ubuntu-latest", dbt: "1.7" } + - { python: "3.11", os: "ubuntu-latest", dbt: "1.8" } # full test matrix on 3.10 (well supported py version) on ubuntu - { python: "3.10", os: "ubuntu-latest", dbt: "1.0" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.1" } @@ -23,6 +26,9 @@ jobs: - { python: "3.10", os: "ubuntu-latest", dbt: "1.3" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.4" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.5" } + - { python: "3.10", os: "ubuntu-latest", dbt: "1.6" } + - { python: "3.10", os: "ubuntu-latest", dbt: "1.7" } + - { python: "3.10", os: "ubuntu-latest", dbt: "1.8" } # full test matrix on 3.9 (well supported py version) on ubuntu - { python: "3.9", os: "ubuntu-latest", dbt: "1.0" } - { python: "3.9", os: "ubuntu-latest", dbt: "1.1" } @@ -30,6 +36,9 @@ jobs: - { python: "3.9", os: "ubuntu-latest", dbt: "1.3" } - { python: "3.9", os: "ubuntu-latest", dbt: "1.4" } - { python: "3.9", os: "ubuntu-latest", dbt: "1.5" } + - { python: "3.9", os: "ubuntu-latest", dbt: "1.6" } + - { python: "3.9", os: "ubuntu-latest", dbt: "1.7" } + - { python: "3.9", os: "ubuntu-latest", dbt: "1.8" } # stability test on 3.8 (min python ver) with latest dbt - { python: "3.8", os: "ubuntu-latest", dbt: "1.5" } # stability test on 3.10 with latest dbt on macos (cross platform) From dcd4a5db5f551c3c0277e8ff2e209fb75b472147 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:21:56 -0300 Subject: [PATCH 03/11] Maintain adapters loosening to support sqlite --- Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index f069b7c..06d1026 100644 --- a/Makefile +++ b/Makefile @@ -58,7 +58,7 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt16/bin/pip install --upgrade wheel setuptools pip .venv-dbt16/bin/pip install pytest WebTest . for adapter in $(ADAPTERS); do \ - .venv-dbt16/bin/pip install "dbt-$$adapter>=1.5.0,<1.7.0"; \ + .venv-dbt16/bin/pip install "dbt-$$adapter>=1.4.0,<1.7.0"; \ .venv-dbt16/bin/pip install "dbt-core>=1.6.0,<1.7.0"; \ done @@ -67,7 +67,7 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt17/bin/pip install --upgrade wheel setuptools pip .venv-dbt17/bin/pip install pytest WebTest . for adapter in $(ADAPTERS); do \ - .venv-dbt17/bin/pip install "dbt-$$adapter>=1.6.0,<1.8.0"; \ + .venv-dbt17/bin/pip install "dbt-$$adapter>=1.4.0,<1.8.0"; \ .venv-dbt17/bin/pip install "dbt-core>=1.7.0,<1.8.0"; \ done @@ -76,10 +76,10 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt18/bin/pip install --upgrade wheel setuptools pip .venv-dbt18/bin/pip install pytest WebTest . for adapter in $(ADAPTERS); do \ - .venv-dbt18/bin/pip install "dbt-$$adapter>=1.7.0,<1.9.0"; \ + .venv-dbt18/bin/pip install "dbt-$$adapter>=1.4.0,<1.9.0"; \ .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ - .venv-dbt18/bin/pip install "dbt-adapters~=1.2.0; \ - .venv-dbt18/bin/pip install "dbt-common~=1.2.0; \ + .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0; \ + .venv-dbt18/bin/pip install "dbt-common>=1.2.0; \ done clean: From 15680ee5076a053d6ebf197cd0f41b5b4e2c6224 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:26:55 -0300 Subject: [PATCH 04/11] Typos on makefile --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 06d1026..2e8f821 100644 --- a/Makefile +++ b/Makefile @@ -78,12 +78,12 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python for adapter in $(ADAPTERS); do \ .venv-dbt18/bin/pip install "dbt-$$adapter>=1.4.0,<1.9.0"; \ .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ - .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0; \ - .venv-dbt18/bin/pip install "dbt-common>=1.2.0; \ + .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0"; \ + .venv-dbt18/bin/pip install "dbt-common>=1.2.0"; \ done clean: - rm -rf .venv-dbt10 .venv-dbt11 .venv-dbt12 .venv-dbt13 .venv-dbt14 .venv-dbt15 + rm -rf .venv-dbt10 .venv-dbt11 .venv-dbt12 .venv-dbt13 .venv-dbt14 .venv-dbt15 .venv-dbt16 .venv-dbt17 .venv-dbt18 .PHONY: clean test-dbt1.0: .venv-dbt10/bin/python From e44209c38f26d22efb808aa4b4b3070d859a1499 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:35:23 -0300 Subject: [PATCH 05/11] Try fixing dbt adapters --- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 2e8f821..ecf98df 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,8 @@ # Makes it easy to create virtual environments for different versions of dbt ADAPTERS = sqlite duckdb -everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt13/bin/python .venv-dbt14/bin/python .venv-dbt15/bin/python +everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt13/bin/python .venv-dbt14/bin/python \ + .venv-dbt15/bin/python .venv-dbt16/bin/python .venv-dbt17/bin/python .venv-dbt18/bin/python .PHONY: everything .venv-dbt10/bin/python: @@ -76,10 +77,10 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt18/bin/pip install --upgrade wheel setuptools pip .venv-dbt18/bin/pip install pytest WebTest . for adapter in $(ADAPTERS); do \ - .venv-dbt18/bin/pip install "dbt-$$adapter>=1.4.0,<1.9.0"; \ .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ - .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0"; \ .venv-dbt18/bin/pip install "dbt-common>=1.2.0"; \ + .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0"; \ + .venv-dbt18/bin/pip install "dbt-$$adapter>=1.4.0,<1.9.0"; \ done clean: From f1910a3f6a4fa33ce4374a5745fb8726697bfd9a Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:53:00 -0300 Subject: [PATCH 06/11] Loosen adapters in 1.8 to any version pip resolves --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ecf98df..9b2f2a6 100644 --- a/Makefile +++ b/Makefile @@ -80,7 +80,7 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ .venv-dbt18/bin/pip install "dbt-common>=1.2.0"; \ .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0"; \ - .venv-dbt18/bin/pip install "dbt-$$adapter>=1.4.0,<1.9.0"; \ + .venv-dbt18/bin/pip install "dbt-$$adapter"; \ done clean: From 4d0fbc77c6a59ab0f8716810c5747fa3bf7ceab6 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 10:58:32 -0300 Subject: [PATCH 07/11] Remove adapters and common --- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index 9b2f2a6..f0318c9 100644 --- a/Makefile +++ b/Makefile @@ -78,8 +78,6 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt18/bin/pip install pytest WebTest . for adapter in $(ADAPTERS); do \ .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ - .venv-dbt18/bin/pip install "dbt-common>=1.2.0"; \ - .venv-dbt18/bin/pip install "dbt-adapters>=1.2.0"; \ .venv-dbt18/bin/pip install "dbt-$$adapter"; \ done From b46fff66445234ee4b4e3c1ad4630fd7410c99bd Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 15:16:39 -0300 Subject: [PATCH 08/11] Fix 1.8 imports and adapter handling, remove sqlite 1.8 testing --- Makefile | 4 ++++ src/dbt_core_interface/project.py | 36 +++++++++++++++++++++++++------ tests/test_main.py | 36 +++++++++++++++---------------- 3 files changed, 51 insertions(+), 25 deletions(-) diff --git a/Makefile b/Makefile index f0318c9..12f7417 100644 --- a/Makefile +++ b/Makefile @@ -72,6 +72,9 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt17/bin/pip install "dbt-core>=1.7.0,<1.8.0"; \ done +# SQLITE adapter is not supported in dbt 1.8+ yet: https://github.com/codeforkjeff/dbt-sqlite/issues +ADAPTERS = duckdb + .venv-dbt18/bin/python: python -m venv .venv-dbt18 .venv-dbt18/bin/pip install --upgrade wheel setuptools pip @@ -80,6 +83,7 @@ everything: .venv-dbt10/bin/python .venv-dbt11/bin/python .venv-dbt12/bin/python .venv-dbt18/bin/pip install "dbt-core>=1.8.0,<1.9.0"; \ .venv-dbt18/bin/pip install "dbt-$$adapter"; \ done + .venv-dbt18/bin/pip install --force-reinstall dbt-adapters dbt-common; clean: rm -rf .venv-dbt10 .venv-dbt11 .venv-dbt12 .venv-dbt13 .venv-dbt14 .venv-dbt15 .venv-dbt16 .venv-dbt17 .venv-dbt18 diff --git a/src/dbt_core_interface/project.py b/src/dbt_core_interface/project.py index 43e92be..dda8976 100644 --- a/src/dbt_core_interface/project.py +++ b/src/dbt_core_interface/project.py @@ -59,6 +59,7 @@ from io import BytesIO from json import dumps as json_dumps from json import loads as json_lds +from multiprocessing import get_context from pathlib import Path from tempfile import NamedTemporaryFile from traceback import format_exc, print_exc @@ -88,7 +89,12 @@ # We maintain the smallest possible surface area of dbt imports from dbt.adapters.factory import get_adapter_class_by_name -from dbt.clients.system import make_directory +try: + # dbt >= 1.8 + from dbt_common.clients.system import make_directory +except ImportError: + # dbt < 1.8 + from dbt.clients.system import make_directory from dbt.config.runtime import RuntimeConfig from dbt.flags import set_from_args from dbt.node_types import NodeType @@ -112,9 +118,16 @@ # These imports are only used for type checking from agate import Table # type: ignore # No stubs for agate from dbt.adapters.base import BaseAdapter, BaseRelation # type: ignore - from dbt.contracts.connection import AdapterResponse + try: + # dbt >= 1.8 + from dbt.adapters.contracts.connection import AdapterResponse + from dbt_common.semver import VersionSpecifier + + except ImportError: + # dbt < 1.8 + from dbt.contracts.connection import AdapterResponse + from dbt.semver import VersionSpecifier from dbt.contracts.results import ExecutionResult, RunExecutionResult - from dbt.semver import VersionSpecifier from dbt.task.runnable import ManifestTask try: @@ -128,9 +141,11 @@ from agate import Table, Number, Text, Column try: - from dbt.clients.agate_helper import Integer + # dbt >= 1.8 + from dbt_common.clients.agate_helper import Integer except ImportError: - from dbt.clients.agate_helper import Number as Integer + # dbt < 1.8 + from dbt.clients.agate_helper import Integer # dbt-core-interface is designed for non-standard use. There is no # reason to track usage of this package. disable_tracking() @@ -266,8 +281,10 @@ class DbtConfiguration: use_experimental_parser: bool = False static_parser: bool = False partial_parse: bool = False - # A required attribute for dbt, not used by our interface + # required attributes for dbt, not used by our interface dependencies: List[str] = field(default_factory=list) + REQUIRE_RESOURCE_NAMES_WITHOUT_SPACES: bool = field(default_factory=bool) + which: str = "blah" def __post_init__(self) -> None: """Post init hook to set single_threaded and remove target if not provided.""" @@ -474,7 +491,12 @@ def initialize_adapter(self) -> None: LOGGER.debug(f"Failed to cleanup adapter connections: {e}") # The adapter.setter verifies connection, resets TTL, and updates adapter ref on config # this is thread safe by virtue of the adapter_mutex on the adapter.setter - self.adapter = self.get_adapter_cls()(self.config) + if (__dbt_major_version__, __dbt_minor_version__) < (1, 8): + self.adapter = self.get_adapter_cls()(self.config) + else: + # from dbt 1.8 adapter decoupling onwwards, + # instantiating an Adapter requires a multiprocessing context. + self.adapter = self.get_adapter_cls()(self.config, get_context("spawn")) @property def adapter(self) -> "BaseAdapter": diff --git a/tests/test_main.py b/tests/test_main.py index be59e5a..ea39d09 100644 --- a/tests/test_main.py +++ b/tests/test_main.py @@ -21,8 +21,8 @@ def test_list(): from dbt_core_interface.project import DbtProject project = DbtProject( - project_dir="demo_sqlite", - profiles_dir="demo_sqlite", + project_dir="demo_duckdb", + profiles_dir="demo_duckdb", target="dev", ) nodes = project.list("*") @@ -58,23 +58,23 @@ def test_server(): client = TestApp(app.default) SIMULATED_CLIENTS = 50 # noqa: N806 - DUCKDB_PROJECTS = ( # noqa: N806 - [ - "j_shop_1_duckdb", - "j_shop_2_duckdb", - "h_niceserver_1_duckdb", - "h_niceserver_2_duckdb", - ] - if (__dbt_major_version__, __dbt_minor_version__) < (1, 4) - else [] # DuckDB adapter is not supported in dbt 1.4+ yet - ) - SQLITE_PROJECTS = [ # noqa: N806 - "j_shop_1_sqlite", - "j_shop_2_sqlite", - "j_shop_3_sqlite", - "j_shop_4_sqlite", - "h_niceserver_1_sqlite", + DUCKDB_PROJECTS = [ # noqa: N806 + "j_shop_1_duckdb", + "j_shop_2_duckdb", + "h_niceserver_1_duckdb", + "h_niceserver_2_duckdb", ] + SQLITE_PROJECTS = ( + [ # noqa: N806 + "j_shop_1_sqlite", + "j_shop_2_sqlite", + "j_shop_3_sqlite", + "j_shop_4_sqlite", + "h_niceserver_1_sqlite", + ] + if (__dbt_major_version__, __dbt_minor_version__) < (1, 8) + else [] + ) # SQLITE adapter is not supported in dbt 1.8+ yet: https://github.com/codeforkjeff/dbt-sqlite/issues PROJECTS = DUCKDB_PROJECTS + SQLITE_PROJECTS # noqa: N806 for proj in SQLITE_PROJECTS: From 659773fc8a8bd84d39b7ec52446db4c5d7cceb73 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 15:21:36 -0300 Subject: [PATCH 09/11] Re-apply old-new Agate import --- src/dbt_core_interface/project.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/dbt_core_interface/project.py b/src/dbt_core_interface/project.py index dda8976..441fdcb 100644 --- a/src/dbt_core_interface/project.py +++ b/src/dbt_core_interface/project.py @@ -144,8 +144,12 @@ # dbt >= 1.8 from dbt_common.clients.agate_helper import Integer except ImportError: - # dbt < 1.8 - from dbt.clients.agate_helper import Integer + try: + # dbt < 1.8 and older Agate version + from dbt.clients.agate_helper import Integer + except ImportError: + # dbt < 1.8 and newer Agate version + from dbt.clients.agate_helper import Number as Integer # dbt-core-interface is designed for non-standard use. There is no # reason to track usage of this package. disable_tracking() From 2636571eea6ebd05197187dcfcfed45fcaf411d6 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Mon, 3 Jun 2024 15:51:31 -0300 Subject: [PATCH 10/11] Add Py3.12 test cases --- .github/workflows/tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 17a6d16..7a65280 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,6 +13,10 @@ jobs: fail-fast: false matrix: include: + # dbt-core now supports Python 3.12 + - { python: "3.12", os: "ubuntu-latest", dbt: "1.6" } + - { python: "3.12", os: "ubuntu-latest", dbt: "1.7" } + - { python: "3.12", os: "ubuntu-latest", dbt: "1.8" } # Latest dbts' test matrix on 3.11 (well supported py version) on ubuntu - { python: "3.11", os: "ubuntu-latest", dbt: "1.4" } - { python: "3.11", os: "ubuntu-latest", dbt: "1.5" } @@ -20,7 +24,6 @@ jobs: - { python: "3.11", os: "ubuntu-latest", dbt: "1.7" } - { python: "3.11", os: "ubuntu-latest", dbt: "1.8" } # full test matrix on 3.10 (well supported py version) on ubuntu - - { python: "3.10", os: "ubuntu-latest", dbt: "1.0" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.1" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.2" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.3" } @@ -30,7 +33,6 @@ jobs: - { python: "3.10", os: "ubuntu-latest", dbt: "1.7" } - { python: "3.10", os: "ubuntu-latest", dbt: "1.8" } # full test matrix on 3.9 (well supported py version) on ubuntu - - { python: "3.9", os: "ubuntu-latest", dbt: "1.0" } - { python: "3.9", os: "ubuntu-latest", dbt: "1.1" } - { python: "3.9", os: "ubuntu-latest", dbt: "1.2" } - { python: "3.9", os: "ubuntu-latest", dbt: "1.3" } From e9e1f776f3b70d696a95b081cffdb0c392d14ce5 Mon Sep 17 00:00:00 2001 From: Bruno Antonellini Date: Tue, 4 Jun 2024 10:17:26 -0300 Subject: [PATCH 11/11] Remove py3.12 support for dbt 1.6: not supported --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7a65280..4f36603 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -14,7 +14,6 @@ jobs: matrix: include: # dbt-core now supports Python 3.12 - - { python: "3.12", os: "ubuntu-latest", dbt: "1.6" } - { python: "3.12", os: "ubuntu-latest", dbt: "1.7" } - { python: "3.12", os: "ubuntu-latest", dbt: "1.8" } # Latest dbts' test matrix on 3.11 (well supported py version) on ubuntu