Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce runtime of spec/requests/datacite_dois_spec.rb #1248

Open
jrhoads opened this issue Sep 20, 2024 · 0 comments
Open

Reduce runtime of spec/requests/datacite_dois_spec.rb #1248

jrhoads opened this issue Sep 20, 2024 · 0 comments
Assignees

Comments

@jrhoads
Copy link
Contributor

jrhoads commented Sep 20, 2024

requests/datacite_dois_spec.rb has been identified in #1241 as one of the specs that is taking the most overall clock time. Which has the knock-on effect of slowing the overall test suite down. Let's see if we can reduce the runtime of this spec.

Current runtime in CI is about 14 minutes.

The file has ~5k lines of code in the spec and has several sleep statements in it.

These are places where we can focus:

  • Perhaps split the spec into multiple smaller specs
  • See if we can remove sleep statements and still retain functional coverage.
@jrhoads jrhoads self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant