Codemods that are not part of the core upgrade process.

[svogt0511]

The 3.24 ember upgrade included changes to the syntax of the .hbs templates involving ids, classes, and other properties on html elements. This caused breakage in both testing and runtime behavior of Fabrica. The modified properties (ids, classes, and other properties) are assumed to be there and relied upon for the correct runtime behavior, especially in forms and power-select.

Every ember upgrade involves running codemods. Codemods are scripts provided by ember module writers. These scripts make mechanical changes to custom code in a project so the developer does not have to do so, saving time. The command is:

ember-cli-update --run-codemods

Normally the codemods scripts work, but this time, many did not, so the hbs files had to be modified manually.

Some of the codemods are described in ember-bootstrap-codemods. Others are described in Upgrade Fabrica to Ember v3.24. Also, warnings may show up as warnings in the developer console if Ember detects a codemod that is needed.

Some of the codemods that needed to be manually implemented are:

• BsButton component: remove @ from title, class, id, and disabled. Orange buttons on doi create/update forms changed appearance (black instead of orange). They need to be orange.
• Power select component: <form.element @controlType="power-select">.
  • @disabled, @Placeholder, @searchEnabled, @allowClear - move from <form.element> to the subordinate <el.control> and keep @.
  • Issues surrounding syntax and placement of @id, @Class. Remove @. These properties can stay in the form.element or moved to subordinate <el.control> depending on where they are needed in the rendered html.
  • Issue mentioned above with @onkeydown in the bootstrap-power-select module not invoking 'createOnEnter'. That
    was fixed by adding a patch command that is run after the build (see package.json, 'postinstall' and patches directory).
  • Add @searchEnabled to <el.control> to enable the search, otherwise it won't work.
• form.element/el.control
  • placeholder, disabled, required, rows, readonly, autofocus, disabled move to el.control. Remove @.
  • id and class - at form.element level, remove @.
  • Add 'id-field' or 'class-field' to el.control. (These are used in testing to identify input fields.)
    See ember-bootstrap-codemods for details.
• Radiobutton component accepts @disabled
• Syntax for using variables in templates changed from <var_name> to {{var_name}}.

[svogt0511]

Closing this issue for now. I think we have gotten all of these.