Skip to content

Commit 2555a6b

Browse files
committed
Found docs on how to escape the slack messages. This better work
1 parent 8ed28dc commit 2555a6b

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

message.go

+5-3
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ func fmtEventMessage(ev hookserve.Event) (msg string) {
2424
}
2525
msg = fmt.Sprintf("*<%v|%v>*:*%v* (%v) \n", ev.Repo.Url, ev.Repo.FullName, ev.Branch, niceTypeMessage(ev.Type))
2626
for _, commit := range ev.Commits {
27-
// escaping # symbol (slack's message syntax is confusing but # has been breaking messages)
28-
escapedMsg := strings.Replace(commit.Message, ">", `\>`, -1)
29-
msg += fmt.Sprintf(" *[<%v|%v>]* <%v|%v>\n", commit.Url, commit.Author.Username, commit.Url, escapedMsg)
27+
// escaping msg as documented at https://api.slack.com/docs/formatting
28+
commit.Message = strings.Replace(commit.Message, "&", `&amp;`, -1)
29+
commit.Message = strings.Replace(commit.Message, ">", `&lt;`, -1)
30+
commit.Message = strings.Replace(commit.Message, "<", `&gt;`, -1)
31+
msg += fmt.Sprintf(" *[<%v|%v>]* <%v|%v>\n", commit.Url, commit.Author.Username, commit.Url, commit.Message)
3032
}
3133
if ev.Branch != "" {
3234
msg += fmt.Sprintf("The branch is %v \n", ev.Branch)

0 commit comments

Comments
 (0)