Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing library installation instructions #478

Closed
fordfishman opened this issue Aug 8, 2023 · 4 comments · Fixed by #483
Closed

Confusing library installation instructions #478

fordfishman opened this issue Aug 8, 2023 · 4 comments · Fixed by #483
Labels
good first issue Good issue for first-time contributors status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR

Comments

@fordfishman
Copy link
Contributor

There are a few inconsistencies in the setup for this lesson. In Summary and Setup, there are some brief instructions for saying to install tidyverse and here. The first episode Before We Start has more detailed instructions and information about installing libraries in general. However, Before We Start only specifically speaks about installing tidyverse and not here. Given that a lot of participants will have trouble installing libraries before the session, that means that at Before We Start, they will likely not have either installed, and will be installing live at the workshop (which is what happened when I ran this workshop with a colleague).

I would recommend adding some text about installing here in Before We Start.

@juanfung
Copy link
Contributor

@fordfishman agreed. this is largely a result of the piecemeal development of the lesson.

Would you be interested in submitting a PR to address the inconsistencies?

@juanfung juanfung added status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR good first issue Good issue for first-time contributors labels Aug 10, 2023
@fordfishman
Copy link
Contributor Author

Sure, I'll submit a PR where I add in installing here into Before We Start.

@fordfishman
Copy link
Contributor Author

A little confused about which branch to use for the PR. Should I be doing a PR off my own custom branch to main or to gh-pages as suggested here? I see that PRs in the past have been merged to main.

@zkamvar
Copy link
Contributor

zkamvar commented Aug 18, 2023

Mea culpa. That contributing is out of date. The updated version is here: https://github.com/zkamvar/r-socialsci/blob/zkamvar-patch-1/CONTRIBUTING.md (and is currently a PR in #480)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants