-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About pivot_wider/longer functions #470
Comments
@msquiroga89 thank you that's great feedback! would you be interested in submitting a PR or providing some suggestions to improve the illustration of the two functions? |
Per discussion with @eirini-zormpa perhaps make this section optional, in addition to improving the example |
This is also something we have discussed in our group, since we rarely have time to make it through all of the code in Data Wrangling with tidyr. And this is a problem since the last part is crucial for continuing with Data Visualisation. I think the tidyr part could be trimmed down by removing the example of making the |
@bbartholdy these are great suggestions! i have assigned this issue to myself, but if you are willing to submit a PR with these suggestions, it would be super appreciated :) |
@juanfung sure! I'll see what I can come up with. On this branch https://github.com/bbartholdy/r-socialsci/tree/tidyr-adjust (for anyone interested). |
Hi, sorry I disappeared, I got caught up in my work. I would like to collaborate with this section of the lesson, are you developing an alternative? |
Hi @msquiroga89, no worries! Yes, I am working on modifications to the episode. It's tricky because it still needs to align with the next episode on data visualisation. My plan was to add a step-by-step walkthrough of pivoting Let me know what your thoughts are. |
@bbartholdy @msquiroga89 just checking in on this issue...let us (maintainers) know if you need any help! |
Thanks @juanfung! I hit a bit of a busy period but should be able to pick it up again after next week. |
@bbartholdy no worries, that sounds good and your contributions are much appreciated! |
I have reorganised the episode as discussed above. I had to deviate a bit from the original plan in order for the episode to make sense (bbartholdy@a9182ce). To summarise:
Still needed:
I wanted to get some input on the new layout before changing the figures (@juanfung , @msquiroga89 ?). |
@bbartholdy thank you for the incredible amount of work you've done on this! apologies for not replying sooner, but i finally had a chance to serve your changes locally and have two comments:
i checked and i have tidyr 1.3.0 installed, so i'm puzzled. i'm not well versed in how workbench works, and whether there is a local environment enforcing package versions (but if there were, i wouldn't be getting an error). just flagging to make sure you double check this all works as intended. i am guessing it's a local problem on my end, but can't figure it out |
It sounds like a local problem, I didn't have any issues, including on a fresh Ubuntu install. I know there were problems with some previous versions of {renv}, so maybe worth updating? It might also be an issue with the way the workbench uses {renv}, but I also don't really know enough about it. |
Hi!
I would like to raise a question about the way
pivot_wider
andpivot_longer
are presented in the R for Social Sciences lesson. It can be a very challenging set of functions, but the fact that we first have to separate rows and create logical variables can be a distracting moment for learners. The transformation needed is difficult, and maybe it’s not easily understandable why we need to do that.We talked about it in the CAC, and since there seem to be other aspects of the dataset to be discussed, we thought that it could be a good opportunity to include a different approach to these functions, like chosing variables that don't need a previous transformation.
Thanks!
The text was updated successfully, but these errors were encountered: