Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teaching feedback #474

Open
davis68 opened this issue Sep 17, 2020 · 1 comment
Open

Teaching feedback #474

davis68 opened this issue Sep 17, 2020 · 1 comment
Labels
good first issue Good issue for first-time contributors type:enhancement Propose enhancement to the lesson

Comments

@davis68
Copy link

davis68 commented Sep 17, 2020

  • I felt like nunique was arbitrarily (re)introduced when it was necessary. It wouldn't be top-of-mind for students solving problems.
  • The lesson answers need to be adjacent to the exercises.
  • I like the pre-introduction of masks and then circling back around to explain them.
  • I feel like Part 4 needs to be broken up and integrated across other lessons: it felt thin on its own.
  • Horizontal concatenation felt odd to include.
  • The join material is pretty good.
  • It'd be good to have an elementary stats module after Part 5 before Part 7, maybe as part of Part 6.
  • The actual functions in Part 6 felt contrived: it'd be nicer to take a complicated problem and simplify it but it feels like taking a simple problem (one file) and complicating it (multiple files).
@maxim-belkin maxim-belkin added the good first issue Good issue for first-time contributors label Apr 27, 2021
@maxim-belkin
Copy link
Contributor

Thanks for the feedback / criticism, Neal. Marking this as a "good first issue", so that those who want to contribute to the lesson can work on some of the issues you mention above.

@quist00 quist00 added the type:enhancement Propose enhancement to the lesson label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

3 participants