Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out dplyr dependency for vctrs #7

Open
hadley opened this issue Jun 23, 2023 · 3 comments
Open

Switch out dplyr dependency for vctrs #7

hadley opened this issue Jun 23, 2023 · 3 comments

Comments

@hadley
Copy link
Contributor

hadley commented Jun 23, 2023

dplyr is a user facing package so it's rather dependency heavy in favour of providing the whole package to users. This means it doesn't feel like a great dependency for an SDK, which wants to be low-level. Fortunately, it should be pretty easy to switch out dplyr for vctrs, which is the low-level equivalent, replacing dplyr::bind_rows() with vctrs::vec_rbind().

@nfx
Copy link
Collaborator

nfx commented Jun 24, 2023

@hadley what license does vctrs package have? I support the idea of using as little transitive dependencies as possible, though we have to go through approvals for any new packages. e.g. I had to remove configr dep for manual parting of INI file for this same purpose.

@hadley
Copy link
Contributor Author

hadley commented Jun 24, 2023

It’s MIT.

@nfx
Copy link
Collaborator

nfx commented Jun 24, 2023

should be easy to get through, then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants