Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated defaults #258

Open
hardbyte opened this issue Jun 13, 2019 · 0 comments
Open

Duplicated defaults #258

hardbyte opened this issue Jun 13, 2019 · 0 comments

Comments

@hardbyte
Copy link
Collaborator

We should rethink defaults as currently:

  • clkhash ignores the values in the spec
  • the defaults are spread throughout the code base. Either hard-coded (e.g. schema.py line 184), default argument values (e.g. field_formats.py line 92, 93), or some hidden configurable variables (e.g. field_formats.py line 85,86).
  • there is no guarantee that the default in the schema correlates to the default in the code
  • if defaults are used the user doesn't actually know the exact details of the schema used to create the CLKs. This makes it unnecessarily hard to reproduce results between tools and even versions of clkhash.

If we have defaults in the schema, we should consider extracting them like this. This way, it would not just be more elegant, but also, it would create a json structure with all values set, which we could then feed back to the user -> the effective schema.

See source at #255 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant