Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box UI Update #366

Open
2 tasks
YolineB opened this issue Feb 7, 2023 · 7 comments
Open
2 tasks

Search box UI Update #366

YolineB opened this issue Feb 7, 2023 · 7 comments
Labels

Comments

@YolineB
Copy link
Contributor

YolineB commented Feb 7, 2023

Mobile view of search box should reflect the following, as seen on Figma

  • Start date / End date need to be halved on mobile
  • region & price split on mobile filter

[Updated 2/10 - Yoline]

@YolineB YolineB added the good first issue Good for newcomers label Feb 7, 2023
@loki1205
Copy link

loki1205 commented Feb 7, 2023

Hi, I would love to work with you on this one. Can you please assign this to me?

@reshamas
Copy link
Contributor

reshamas commented Feb 8, 2023

Hi, I would love to work with you on this one. Can you please assign this to me?

@loki1205 Yes, this issue is available. If you could submit a PR within the next couple of days, that would be great.

@loki1205
Copy link

loki1205 commented Feb 9, 2023

Hi, I am unable to see the Figma file. I have requested access. Kindly accept it and let me know.

@reshamas
Copy link
Contributor

reshamas commented Feb 9, 2023

@iliadeleon
Are you able to add the screenshot here on GitHub?

@loki1205

This comment was marked as outdated.

@YolineB
Copy link
Contributor Author

YolineB commented Feb 10, 2023

@loki1205 I do not have the latest version, but the search box will look similar to the screenshot below. Please note that the categories have changed to the following:

-Start Date
-End Date
-Event Type
-Topic
-Language
-Region
-Price

Start Date/End Date and Region/Price (instead of Category / Price ) will be the two split boxes

image

@loki1205 loki1205 removed their assignment Feb 11, 2023
@YolineB
Copy link
Contributor Author

YolineB commented Feb 14, 2023

Hello @loki1205, here is an updated figma design for the search box - let me know if you have any questions! Please note that we do request PRs for good first issues to be completed by February 17.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants