Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarter Dropdown Menu selects wrong next quarter #90

Open
adamw3455 opened this issue Oct 30, 2024 · 0 comments
Open

Quarter Dropdown Menu selects wrong next quarter #90

adamw3455 opened this issue Oct 30, 2024 · 0 comments

Comments

@adamw3455
Copy link

Expected Behavior:

Quarter Dropdown Menu provides options to select current quarter (Fall 2024) and next quarter (Winter 2025)

Actual Behavior:

Quarter Dropdown Menu gives options for correct current quarter (Fall 2024), but incorrect next quarter (Spring 2025)
image

Cause:

image
quarters() (from backend-api.js) is called with the incorrect date argument (by util-methods.js getQuarters()).
./frontend/src/components/util/util-methods.js has an error in the implementation of the getQuarters() function, setting nextQuarter variable to a time 8 months in the future (today+2+6), which is in the wrong quarter. The correct behavior, which is actually on this repo, sets nextQuarter to a time 4 months in the future (today+2+2).

Incorrect Production Code (util-methods.js line 53)

image

Correct Github Code (util-methods.js line 57)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant