Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users when they approve share requests with Write/Modify permissions #1566

Open
petrkalos opened this issue Sep 20, 2024 · 6 comments
Open

Warn users when they approve share requests with Write/Modify permissions #1566

petrkalos opened this issue Sep 20, 2024 · 6 comments
Assignees
@petrkalos

Comments

@petrkalos
Copy link
Contributor

Currently the share view indicates the requested permissions but given that customers are used to Read-only nature of data.all it might be good to implement a warning mechanism to increase awareness.

My suggestions, first one is much simpler to implement but the second is more assertive.

  1. Only for Write/Modify share requests display a sizeable warning as a subheader in the ShareView
    image

  2. Only for Write/Modify share requests create a confirmation pop-up when clicking the Approve button
    image
@petrkalos petrkalos changed the title Warn users when they approve share requests with Write/Modify permissions? Warn users when they approve share requests with Write/Modify permissions Sep 20, 2024
@dlpzx
Copy link
Contributor

dlpzx commented Sep 20, 2024

I kind of like the second one better, but waiting to see what the rest think

@petrkalos petrkalos self-assigned this Sep 20, 2024
@petrkalos petrkalos added this to v2.7.0 Sep 20, 2024
@github-project-automation github-project-automation bot moved this to Nominated in v2.7.0 Sep 20, 2024
@petrkalos petrkalos moved this from Nominated to In progress in v2.7.0 Sep 20, 2024
@anushka-singh
Copy link
Contributor

I like option 2 better!

@zsaltys
Copy link
Contributor

zsaltys commented Sep 20, 2024

I like option 2.. I prefer a user confirms explicitly they definitely want write permissions to be granted. Then there's no excuse 'I didn't see it'

@TejasRGitHub
Copy link
Contributor

I like option 2 as well.

@petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?

@petrkalos
Copy link
Contributor Author

I like option 2 as well.

@petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?

No I am thinking only if it's not read-only

@petrkalos petrkalos mentioned this issue Sep 23, 2024
Merged
@petrkalos
Copy link
Contributor Author

@zsaltys @TejasRGitHub as discussed see #1568

SofiaSazonova pushed a commit that referenced this issue Oct 2, 2024
@petrkalos
warn users when evaluating a non-readonly share request (#1568)
b177279 
### Feature or Bugfix
- Feature

### Detail
If and only if the request permissions include Write/Modify
* when then approver clicks on `Approve` they get a confirmation pop-up

![image](https://github.com/user-attachments/assets/11f9d27f-e518-481e-9a13-87dafd18b9d2)
* In the shareview page a warning triangle ⚠️ is added next to the
`Permissions` row

![image](https://github.com/user-attachments/assets/9b07e0d3-e92f-498d-9415-533d3e2db1be)





### Relates
Solves #1566 

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrkalos petrkalos

Labels
None yet
Projects
v2.7.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@petrkalos @zsaltys @anushka-singh @TejasRGitHub @dlpzx