Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: create_diagonal: support broadcasting #136

Open
NeilGirdhar opened this issue Feb 6, 2025 · 1 comment · May be fixed by #137
Open

ENH: create_diagonal: support broadcasting #136

NeilGirdhar opened this issue Feb 6, 2025 · 1 comment · May be fixed by #137
Labels
enhancement New feature or request

Comments

@NeilGirdhar
Copy link
Contributor

NeilGirdhar commented Feb 6, 2025 •
edited
Loading

Thus, the docstring would be something like:

    """A vectorized version of diagonal.

    Args:
        m: Has shape (*k, n)
    Returns: Array with shape (*k, n, n) and the elements of m on the diagonals.
    """

If this is okay, I can submit a PR
@lucascolley
Copy link
Member

feel free to submit a PR!

@lucascolley lucascolley changed the title Make create_diagonal support broadcasting ENH: create_diagonal: support broadcasting Feb 7, 2025
@lucascolley lucascolley added the enhancement New feature or request label Feb 7, 2025
@NeilGirdhar NeilGirdhar linked a pull request Feb 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: create_diagonal: support broadcasting NeilGirdhar/array-api-extra
2 participants
@NeilGirdhar @lucascolley