Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failures for main/k8s tests has been introduced without changes in this repo #522

Closed
consideRatio opened this issue Apr 5, 2022 · 5 comments

Comments

@consideRatio
Copy link
Collaborator

In this old test run of a recent commit, all tests passed. In this newer test run of the same commit (manually triggered) we now have failures in the Python 3.7 test and all the k8s tests.

Something changed outside this repo, but what?

Pip list differences

The previous worked, the new didn't. but something else can also be the cause.

-click==8.0.4
+click==8.1.2
-fsspec==2022.2.0
+fsspec==2022.3.0
-ipykernel==6.9.2
+ipykernel==6.11.0
-jupyter-client==7.1.2
+jupyter-client==7.2.1
-nbconvert==6.4.4
+nbconvert==6.4.5
-nest-asyncio==1.5.4
+nest-asyncio==1.5.5
-SQLAlchemy==1.4.32
+SQLAlchemy==1.4.34
-zipp==3.7.0
+zipp==3.8.0
@martindurant
Copy link
Member

I did see click implicated in some breakages elsewhere, but I don't remember quite where.

@consideRatio
Copy link
Collaborator Author

I narrowed it down, this is worked around by avoiding click 8.1.0, 8.1.1, and 8.1.2 (latest), but I couldn't figure out what changed in click that caused this.

@consideRatio
Copy link
Collaborator Author

Sadly this did only resolve the issue for the py37 test, not for all the k8s tests. I don't get whats the problem there still, but have started suspecting memory issues.

@consideRatio
Copy link
Collaborator Author

Ah... I realized now that click probably is too blame also in the k8s tests. It just was that the setup.py defined version constraint wasn't respected by our Dockerfile's. I opened #524 about this.

@consideRatio
Copy link
Collaborator Author

I'll let this be closed by #525 and open a new about fixing compatebility with click 8.1.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants