From c5eb184859d70503ca262690522987b8e69361c5 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Thu, 30 Jan 2025 02:32:40 +0300 Subject: [PATCH 1/2] fix: port 0 is not a bad one 6535 follow-up --- src/netbase.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netbase.cpp b/src/netbase.cpp index d44645821c282..5c704f3b772d6 100644 --- a/src/netbase.cpp +++ b/src/netbase.cpp @@ -709,7 +709,7 @@ bool IsBadPort(uint16_t port) { /* Don't forget to update doc/p2p-bad-ports.md if you change this list. */ - if (port <= PRIVILEGED_PORTS_THRESHOLD) return true; + if (port > 0 && port <= PRIVILEGED_PORTS_THRESHOLD) return true; switch (port) { case 1719: // h323gatestat case 1720: // h323hostcall From 8c30f7330979b9fde5724e486325deb9e255d1d5 Mon Sep 17 00:00:00 2001 From: UdjinM6 Date: Thu, 30 Jan 2025 02:43:11 +0300 Subject: [PATCH 2/2] test: check port 0 in netbase_tests.cpp --- src/test/netbase_tests.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/netbase_tests.cpp b/src/test/netbase_tests.cpp index 950c58a20865f..54de53fd480e5 100644 --- a/src/test/netbase_tests.cpp +++ b/src/test/netbase_tests.cpp @@ -450,6 +450,7 @@ BOOST_AUTO_TEST_CASE(isbadport) BOOST_CHECK(IsBadPort(18332)); BOOST_CHECK(IsBadPort(18333)); + BOOST_CHECK(!IsBadPort(0)); BOOST_CHECK(!IsBadPort(9998)); BOOST_CHECK(!IsBadPort(9999)); BOOST_CHECK(!IsBadPort(26656));