Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of fragile, undocumented way to get avatar url #1

Open
dartrax opened this issue Jan 3, 2021 · 0 comments
Open

Get rid of fragile, undocumented way to get avatar url #1

dartrax opened this issue Jan 3, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dartrax
Copy link
Owner

dartrax commented Jan 3, 2021

@mundschenk-at wrote:

The assumptions regarding hash generation will probably not hold forever and so the current implementation is very, very fragile. In fact, it will probably not work for some people today because Avatar Privacy up to and including 2.3.x encodes the “object type” (anonymous comment or registered user) into the subdirectory, without even considering local avatars, default avatars etc.
The subdirectory is generated here, though I’ve removed that logic from (the currently unreleased) version 2.4.0.

More on that here

@dartrax dartrax added the enhancement New feature or request label Jan 3, 2021
@dartrax dartrax self-assigned this Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant