Skip to content

Commit d3448ba

Browse files
authored
Remove last element1 use (#752)
* Remove last element1 use. * Call noname constructor as before. * Use renamed `build` method.
1 parent c5aabf9 commit d3448ba

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

source_gen/lib/src/constants/revive.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// TODO(kevmoo): migrate analyzer APIs when we can get latest with a stable SDK
6-
// ignore_for_file: deprecated_member_use
7-
85
import 'package:analyzer/dart/constant/value.dart';
96
import 'package:analyzer/dart/element/element2.dart';
107
import 'package:analyzer/dart/element/type.dart';
@@ -82,9 +79,10 @@ Revivable reviveInstance(DartObject object, [LibraryElement2? origin]) {
8279
final i = (object as DartObjectImpl).getInvocation();
8380
if (i != null) {
8481
url = Uri.parse(urlOfElement(i.constructor2.enclosingElement2));
82+
String newToEmpty(String string) => string == 'new' ? '' : string;
8583
final result = Revivable._(
8684
source: url,
87-
accessor: i.constructor.name,
85+
accessor: newToEmpty(i.constructor2.name3!),
8886
namedArguments: i.namedArguments,
8987
positionalArguments: i.positionalArguments,
9088
);

source_gen/test/generator_for_annotation_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ class _TestingResolver implements ReleasableResolver {
317317
}
318318

319319
@override
320-
Future<LibraryElement2> libraryFor2(
320+
Future<LibraryElement2> libraryFor(
321321
AssetId assetId, {
322322
bool allowSyntaxErrors = false,
323323
}) async {

0 commit comments

Comments
 (0)