Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] DevTools 2.42.1 #59898

Open
elliette opened this issue Jan 13, 2025 · 1 comment
Open

[CP] DevTools 2.42.1 #59898

elliette opened this issue Jan 13, 2025 · 1 comment
Assignees
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged. cherry-pick-review Issue that need cherry pick triage to approve triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.

Comments

@elliette
Copy link
Contributor

elliette commented Jan 13, 2025

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/403946

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/403946

Issue Description

  1. The DevTools analytics is missing data in its analytics to distinguish whether events are coming from the new or legacy inspector. This is because the parameter that was added is a boolean, but Google Analytics 4 only supports string or int values.

  2. The DevTools analytics for exceptions include a truncated stacktrace, which sometimes doesn't contain any DevTools frames. This makes it hard to debug those exceptions.

Why cherry-pick

  1. Without being able to distinguish between the new and legacy inspector events, we are unable to monitor the rollout of the new inspector and mitigate any issues that arise.

  2. By always including the DevTools frames in any exception stacktraces sent to analytics, it makes it easier for us to debug any exceptions occurring in DevTools.

Risk

Low

Issue link(s)

  1. [Inspector V2] Analytics do not distinguish between new and legacy inspector flutter/devtools#8690
  2. Include Devtools frames in stacktraces sent to analytics flutter/devtools#8698
@elliette elliette added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 13, 2025
@dart-github-bot
Copy link
Collaborator

Summary: DevTools 2.42.1 analytics lacks data differentiating new/legacy inspector events due to an incompatible boolean parameter. This prevents monitoring the new inspector's rollout.

@dart-github-bot dart-github-bot added area-google3 Tracking issues for internal work. Note that this area is not triaged. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged. cherry-pick-review Issue that need cherry pick triage to approve triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.
Projects
None yet
Development

No branches or pull requests

6 participants