Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assist "Convert to single/double quoted string" #40888

Open
a14n opened this issue Mar 5, 2020 · 1 comment · May be fixed by #56723
Open

Improve assist "Convert to single/double quoted string" #40888

a14n opened this issue Mar 5, 2020 · 1 comment · May be fixed by #56723
Labels
analyzer-quick-fix area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P4 type-enhancement A request for a change that isn't a bug

Comments

@a14n
Copy link
Contributor

a14n commented Mar 5, 2020

The assist Convert to single/double quoted string is not available for some cases that could be handled. Moreover the convertion should remove backslashes when they are useless.

Here's what should works for Convert to double quoted string:

  • 'it\'s' -> "it's" (currently convert to "it\'s")
  • 'it"s' -> "it\"s" (currently no assist suggested)
@a14n
Copy link
Contributor Author

a14n commented Mar 5, 2020

/cc @bwilkerson

@mraleph mraleph added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Mar 5, 2020
@srawlins srawlins added the P4 label Nov 10, 2020
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Nov 29, 2021
@srawlins srawlins added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label May 20, 2022
@FMorschel FMorschel linked a pull request Sep 12, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-quick-fix area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P4 type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants