Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Dart doc pages #8398

Closed
Pante opened this issue Dec 11, 2024 · 9 comments · Fixed by #8401
Closed

Missing Dart doc pages #8398

Pante opened this issue Dec 11, 2024 · 9 comments · Fixed by #8401

Comments

@Pante
Copy link

Pante commented Dec 11, 2024

We just noticed that most of the previously working links in the generated dart docs for our project, https://pub.dev/documentation/forui/latest/ now return a 404 error. The links in a locally generated copy of the docs on Dart SDK version: 3.5.4 (stable) (Wed Oct 16 16:18:51 2024 +0000) on "macos_arm64" seem to work fine.

@isoos
Copy link
Collaborator

isoos commented Dec 11, 2024

@Pante: the linked page works for me, do you still get 404?

We are rolling out a new site release, and it may be related to that, although, in general we should fall back without such glitches to the previous release's documentation pages.

@Pante
Copy link
Author

Pante commented Dec 11, 2024

I think the issue is with the links on the main page, such as https://pub.dev/documentation/forui/latest/forui.assets, and not the main page itself. I just tested those links again in a private tab and they’re still returning 404 errors.

@isoos
Copy link
Collaborator

isoos commented Dec 11, 2024

Hm, it seems to be partially generated, not sure what went wrong (we have a few moving parts right now). I will investigate this soon.

@isoos
Copy link
Collaborator

isoos commented Dec 12, 2024

I have found an unrelated dartdoc glitch that doesn't affect this (dart-lang/dartdoc#3943).

The core issue here seems to be that dartdoc switched to generate dots as part of the library directories and our path parsing thought that these are just regular files. E.g. https://pub.dev/documentation/forui/latest/forui.widgets.alert/index.html works, while https://pub.dev/documentation/forui/latest/forui.widgets.alert does not (neither with the / suffix).

I'm submitting a quick fix for that and we shall rewrite the current detection mechanism to have proper file checks in our blob index.

@Pante
Copy link
Author

Pante commented Dec 12, 2024

Thanks for the quick turn around!

@isoos
Copy link
Collaborator

isoos commented Dec 12, 2024

Note: the fix is not immediately released, it may take some time before we have the next site release.

@Pante
Copy link
Author

Pante commented Dec 12, 2024

What timeframe are we looking at? Like days, weeks, months?

@sigurdm
Copy link
Contributor

sigurdm commented Dec 12, 2024

Usually we have ~1 deployment per week (modulo things like vacations)

Today you are lucky, and you can expect this to come online within hours!

@isoos
Copy link
Collaborator

isoos commented Dec 12, 2024

Note: this is now online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants