Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure we're testing test_data/**/test #1525

Open
HosseinYousefi opened this issue Sep 6, 2024 · 1 comment
Open

Making sure we're testing test_data/**/test #1525

HosseinYousefi opened this issue Sep 6, 2024 · 1 comment

Comments

@HosseinYousefi
Copy link
Member

For example we seem not to be testing https://github.com/dart-lang/native/blob/main/pkgs/native_assets_builder/test_data/treeshaking_native_libs/test/treeshaking_native_libs_test.dart

As seen here: https://github.com/dart-lang/sdk/blob/main/pkg/dartdev/test/native_assets/test_test.dart

What if we have a test_runner.yaml file that needs to exist for every test_data that has a test/ directory. This is verifiable through CI. The logic in the sdk test could iterate through test_runner.yaml files and verify that everything works correctly.

@dcharkes @mosuem

@mosuem
Copy link
Member

mosuem commented Sep 6, 2024

Do we want to run those tests? I thought we didn't. I use them for manual testing during development only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants