Skip to content

Commit fbfb900

Browse files
committed
speculative windows fix
1 parent fed0f7f commit fbfb900

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

pkgs/native_toolchain_c/test/clinker/objects_helper.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,10 @@ Future<void> runObjectTests(
6666
expect(codeAssets, hasLength(1));
6767
final asset = codeAssets.first;
6868
expect(asset, isA<CodeAsset>());
69-
await expectSymbols(asset: asset, symbols: ['my_func', 'my_other_func']);
69+
expect(
70+
await nmReadSymbols(asset),
71+
stringContainsInOrder(['my_func', 'my_other_func']),
72+
);
7073
});
7174
}
7275
}

pkgs/native_toolchain_c/test/helpers.dart

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -257,19 +257,6 @@ Future<String> nmReadSymbols(CodeAsset asset) async {
257257
return result.stdout;
258258
}
259259

260-
Future<void> expectSymbols({
261-
required CodeAsset asset,
262-
required List<String> symbols,
263-
}) async {
264-
if (Platform.isLinux || Platform.isMacOS) {
265-
final nmOutput = await nmReadSymbols(asset);
266-
267-
expect(nmOutput, stringContainsInOrder(symbols));
268-
} else {
269-
throw UnimplementedError();
270-
}
271-
}
272-
273260
Future<int> textSectionAddress(Uri dylib) async {
274261
if (Platform.isMacOS) {
275262
// Find the line in the objdump output that looks like:

0 commit comments

Comments
 (0)