Formatted and fixed lints

Author: Levi-Lesches

analysis_options.yaml

@@ -40,5 +40,3 @@ linter:
     use_super_parameters: true
     # jni rules
     prefer_const_declarations: true
-    # native_assets_builder rules
-    prefer_expression_function_bodies: true

pkgs/ffi/example/main.dart

@@ -15,7 +15,7 @@ void main() {
 
   // Use the Utf8 helper to encode zero-terminated UTF-8 strings in native
   // memory.
-  final myString = '😎👿💬';
+  const myString = '😎👿💬';
   final charPointer = myString.toNativeUtf8();
   print('First byte is: ${charPointer.cast<Uint8>().value}');
   print(charPointer.toDartString());

pkgs/ffi/test/allocation_test.dart

@@ -24,11 +24,11 @@ void main() async {
 
   test('testPointerAllocateTooLarge', () {
     // Try to allocate something that doesn't fit in 64 bit address space.
-    final maxInt = 9223372036854775807; // 2^63 - 1
+    const maxInt = 9223372036854775807; // 2^63 - 1
     expect(() => calloc<Uint8>(maxInt), throwsA(isA<ArgumentError>()));
 
     // Try to allocate almost the full 64 bit address space.
-    final maxInt1_8 = 1152921504606846975; // 2^60 -1
+    const maxInt1_8 = 1152921504606846975; // 2^60 -1
     expect(() => calloc<Uint8>(maxInt1_8), throwsA(isA<ArgumentError>()));
   });
 

pkgs/ffi/test/utf16_test.dart

@@ -9,7 +9,7 @@ import 'package:test/test.dart';
 
 void main() {
   test('toUtf16 ASCII', () {
-    final start = 'Hello World!\n';
+    const start = 'Hello World!\n';
     final converted = start.toNativeUtf16().cast<Uint16>();
     final end = converted.asTypedList(start.codeUnits.length + 1);
     final matcher = equals(start.codeUnits.toList()..add(0));
@@ -18,7 +18,7 @@ void main() {
   });
 
   test('toUtf16 emoji', () {
-    final start = '😎';
+    const start = '😎';
     final converted = start.toNativeUtf16().cast();
     final length = start.codeUnits.length;
     final end = converted.cast<Uint16>().asTypedList(length + 1);
@@ -28,38 +28,38 @@ void main() {
   });
 
   test('from Utf16 ASCII', () {
-    final string = 'Hello World!\n';
+    const string = 'Hello World!\n';
     final utf16Pointer = string.toNativeUtf16();
     final stringAgain = utf16Pointer.toDartString();
     expect(stringAgain, string);
     calloc.free(utf16Pointer);
   });
 
   test('from Utf16 emoji', () {
-    final string = '😎';
+    const string = '😎';
     final utf16Pointer = string.toNativeUtf16();
     final stringAgain = utf16Pointer.toDartString();
     expect(stringAgain, string);
     calloc.free(utf16Pointer);
   });
 
   test('zero bytes', () {
-    final string = 'Hello\x00World!\n';
+    const string = 'Hello\x00World!\n';
     final utf16Pointer = string.toNativeUtf16();
     final stringAgain = utf16Pointer.toDartString(length: 13);
     expect(stringAgain, string);
     calloc.free(utf16Pointer);
   });
 
   test('length', () {
-    final string = 'Hello';
+    const string = 'Hello';
     final utf16Pointer = string.toNativeUtf16();
     expect(utf16Pointer.length, 5);
     calloc.free(utf16Pointer);
   });
 
   test('fromUtf8 with negative length', () {
-    final string = 'Hello';
+    const string = 'Hello';
     final utf16 = string.toNativeUtf16();
     expect(() => utf16.toDartString(length: -1), throwsRangeError);
     calloc.free(utf16);

pkgs/ffi/test/utf8_test.dart

@@ -17,7 +17,7 @@ Pointer<Uint8> _bytesFromList(List<int> ints) {
 
 void main() {
   test('toUtf8 ASCII', () {
-    final start = 'Hello World!\n';
+    const start = 'Hello World!\n';
     final converted = start.toNativeUtf8().cast<Uint8>();
     final end = converted.asTypedList(start.length + 1);
     final matcher = equals(
@@ -36,7 +36,7 @@ void main() {
   });
 
   test('toUtf8 emoji', () {
-    final start = '😎👿💬';
+    const start = '😎👿💬';
     final converted = start.toNativeUtf8().cast<Utf8>();
     final length = converted.length;
     final end = converted.cast<Uint8>().asTypedList(length + 1);
@@ -100,7 +100,7 @@ void main() {
   });
 
   test('length', () {
-    final string = 'Hello';
+    const string = 'Hello';
     final utf8Pointer = string.toNativeUtf8();
     expect(utf8Pointer.length, 5);
     calloc.free(utf8Pointer);
@@ -117,7 +117,7 @@ void main() {
   });
 
   test('zero terminated', () {
-    final string = 'Hello';
+    const string = 'Hello';
     final utf8Pointer = string.toNativeUtf8();
     final charPointer = utf8Pointer.cast<Char>();
     expect(charPointer[utf8Pointer.length], 0);

pkgs/ffigen/lib/src/code_generator/writer.dart

@@ -192,7 +192,7 @@ class Writer {
 
     /// Finding a unique prefix for Array Helper Classes and store into
     /// [_arrayHelperClassPrefix].
-    final base = 'ArrayHelper';
+    const base = 'ArrayHelper';
     _arrayHelperClassPrefix = base;
     var suffixInt = 0;
     for (var i = 0; i < allNameSet.length; i++) {

pkgs/ffigen/lib/src/header_parser/sub_parsers/compounddecl_parser.dart

@@ -278,7 +278,7 @@ void _compoundMembersVisitor(
         // Anonymous members are always unnamed. To avoid environment-
         // dependent naming issues with the generated code, we explicitly
         // use the empty string as spelling.
-        final spelling = '';
+        const spelling = '';
 
         parsed.compound.members.add(
           CompoundMember(

pkgs/ffigen/lib/src/header_parser/sub_parsers/macro_parser.dart

@@ -167,7 +167,7 @@ late Set<String> _macroVarNames;
 /// Creates a temporary file for parsing macros in current directory.
 File createFileForMacros() {
   final fileNameBase = p.normalize(p.join(strings.tmpDir, 'temp_for_macros'));
-  final fileExt = 'hpp';
+  const fileExt = 'hpp';
 
   // Find a filename which doesn't already exist.
   var file = File('$fileNameBase.$fileExt');

pkgs/ffigen/test/code_generator_tests/code_generator_test.dart

@@ -601,7 +601,7 @@ void main() {
     });
 
     test('Adds Native symbol on mismatch', () {
-      final nativeConfig = const FfiNativeConfig(enabled: true);
+      const nativeConfig = FfiNativeConfig(enabled: true);
       final library = Library(
         name: 'init_dylib',
         header:

pkgs/ffigen/test/config_tests/compiler_opts_test.dart

@@ -13,7 +13,7 @@ import '../test_utils.dart';
 void main() {
   group('compiler_opts_test', () {
     test('Compiler Opts', () {
-      final opts =
+      const opts =
           '''--option value "in double quotes" 'in single quotes'  -tab=separated''';
       final list = compilerOptsToList(opts);
       expect(