From 5f14d4f1ea8728d75c32e7a77170a56a1c5b9999 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Thu, 31 Aug 2023 15:42:23 -0700 Subject: [PATCH 1/2] Avoid passing a nullable value to Future.value This is cleanup work required to start enforcing this with static analysis, as per https://github.com/dart-lang/sdk/issues/53253. Real quick this issue is that this code is unsafe: ```dart void f(Completer c, int? i) { Future.value(i); // Ouch! c.complete(i); // Ouch! } ``` --- build_test/lib/src/written_asset_reader.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_test/lib/src/written_asset_reader.dart b/build_test/lib/src/written_asset_reader.dart index a9c9e3eb1..52db3fbe1 100644 --- a/build_test/lib/src/written_asset_reader.dart +++ b/build_test/lib/src/written_asset_reader.dart @@ -51,7 +51,7 @@ class WrittenAssetReader extends MultiPackageAssetReader { if (!source.assets.containsKey(id)) { throw AssetNotFoundException(id); } - return Future.value(source.assets[id]); + return Future.value(source.assets[id]!); } @override From 882c81232cbfd6e5bc090e74cdc4e1ff89e36fd6 Mon Sep 17 00:00:00 2001 From: Jake Macdonald Date: Fri, 1 Sep 2023 15:29:49 +0000 Subject: [PATCH 2/2] update pubspec/changelog --- build_test/CHANGELOG.md | 4 ++++ build_test/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/build_test/CHANGELOG.md b/build_test/CHANGELOG.md index 958529e29..2ce9d9074 100644 --- a/build_test/CHANGELOG.md +++ b/build_test/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.2.1-dev + +- Avoid passing a nullable value to `Future.value`. + ## 2.2.0 - Forward logs from `testBuilder` to `printOnFailure` by default. diff --git a/build_test/pubspec.yaml b/build_test/pubspec.yaml index d0081491d..29c3cb446 100644 --- a/build_test/pubspec.yaml +++ b/build_test/pubspec.yaml @@ -1,6 +1,6 @@ name: build_test description: Utilities for writing unit tests of Builders. -version: 2.2.0 +version: 2.2.1-dev repository: https://github.com/dart-lang/build/tree/master/build_test environment: