Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_runner and build_daemon should be updated to use web_socket_channel 3.0.0. #3678

Closed
bc-lee opened this issue May 9, 2024 · 3 comments
Labels
needs-info Additional information needed from the issue author

Comments

@bc-lee
Copy link

bc-lee commented May 9, 2024

Recently, web_socket_channel has released a new version 3.0.0, which has breaking changes. There are several breaking changes in the new version, but I believe other than test code in build_runner, build_runner and build_daemon are not affected by the breaking changes.

Relevant issue in web_socket_channel: dart-lang/web_socket_channel#340

Steps to Reproduce

  1. Create a project with build_runner: ^2.4.9 and web_socket_channel: ^2.4.4. It should work fine.
  2. Upgrade web_socket_channel to ^3.0.0.

Actual results

Command failed: flutter pub upgrade web_socket_channel
Because build_runner 2.4.9 depends on web_socket_channel ^2.0.0 and no versions of build_runner match >2.4.9 <3.0.0, build_runner ^2.4.9 requires web_socket_channel ^2.0.0.
So, because apprtc_ng depends on both web_socket_channel ^3.0.0 and build_runner ^2.4.9, version solving failed.

Environment

Flutter 3.19.6 with Dart 3.3.4 and MacOS 14.4.1, though host OS should not matter.

@bc-lee
Copy link
Author

bc-lee commented May 9, 2024

cc. @brianquinlan

@jakemac53
Copy link
Contributor

I tried to do this but it isn't clear how to migrate our tests so I am blocked on dart-lang/web_socket_channel#358 for now.

@brianquinlan
Copy link
Contributor

This should have been fixed as of the 4.0.2 release of package:build_daemon:
https://github.com/dart-lang/build/blob/master/build_daemon/pubspec.yaml#L22

and the 2.4.10 release of package:build_runner:
https://github.com/dart-lang/build/blob/master/build_runner/pubspec.yaml#L48

Can we close the issue now?

@brianquinlan brianquinlan added the needs-info Additional information needed from the issue author label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Additional information needed from the issue author
Projects
None yet
Development

No branches or pull requests

3 participants