fix strict top level inference lints

jakemac53 · jakemac53 · commit ff246d658997 · 2025-01-02T22:27:21.000Z
diff --git a/_test/pkgs/provides_builder/lib/builders.dart b/_test/pkgs/provides_builder/lib/builders.dart
@@ -65,4 +65,4 @@ Builder someBuilder(BuilderOptions options) =>
 Builder notApplied(BuilderOptions options) => _SomeBuilder.fromOptions(options);
 PostProcessBuilder somePostProcessBuilder(BuilderOptions options) =>
     _SomePostProcessBuilder.fromOptions(options);
-Builder throwingBuilder(_) => _ThrowingBuilder();
+Builder throwingBuilder(BuilderOptions _) => _ThrowingBuilder();
diff --git a/build_modules/CHANGELOG.md b/build_modules/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 5.0.11-wip
+
 ## 5.0.10
 
 - Bump the min sdk to 3.6.0.
diff --git a/build_modules/lib/builders.dart b/build_modules/lib/builders.dart
@@ -7,6 +7,6 @@ import 'build_modules.dart';
 import 'src/module_cleanup.dart';
 import 'src/module_library_builder.dart';
 
-Builder moduleLibraryBuilder(_) => const ModuleLibraryBuilder();
+Builder moduleLibraryBuilder(BuilderOptions _) => const ModuleLibraryBuilder();
 
-PostProcessBuilder moduleCleanup(_) => const ModuleCleanup();
+PostProcessBuilder moduleCleanup(BuilderOptions _) => const ModuleCleanup();
diff --git a/build_modules/pubspec.yaml b/build_modules/pubspec.yaml
@@ -1,5 +1,5 @@
 name: build_modules
-version: 5.0.10
+version: 5.0.11-wip
 description: >-
   Builders to analyze and split Dart code into individually compilable modules
   based on imports.
diff --git a/build_resolvers/CHANGELOG.md b/build_resolvers/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 2.4.4-wip
+
 ## 2.4.3
 
 - Require the latest analyzer, and stop passing the `withNullability`
diff --git a/build_resolvers/lib/builder.dart b/build_resolvers/lib/builder.dart
@@ -10,7 +10,8 @@ import 'package:crypto/crypto.dart';
 
 import 'src/build_asset_uri_resolver.dart';
 
-Builder transitiveDigestsBuilder(_) => _TransitiveDigestsBuilder();
+Builder transitiveDigestsBuilder(BuilderOptions _) =>
+    _TransitiveDigestsBuilder();
 
 PostProcessBuilder transitiveDigestCleanup(BuilderOptions options) =>
     FileDeletingBuilder([transitiveDigestExtension],
diff --git a/build_resolvers/pubspec.yaml b/build_resolvers/pubspec.yaml
@@ -1,5 +1,5 @@
 name: build_resolvers
-version: 2.4.3
+version: 2.4.4-wip
 description: Resolve Dart code in a Builder
 repository: https://github.com/dart-lang/build/tree/master/build_resolvers
 resolution: workspace
diff --git a/build_test/CHANGELOG.md b/build_test/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 2.2.4-wip
+
 ## 2.2.3
 
 - Bump the min sdk to 3.6.0.
diff --git a/build_test/lib/builder.dart b/build_test/lib/builder.dart
@@ -2,12 +2,16 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:build/build.dart';
+
 import 'src/debug_test_builder.dart';
 import 'src/test_bootstrap_builder.dart';
 
 export 'src/debug_test_builder.dart' show DebugTestBuilder;
 export 'src/test_bootstrap_builder.dart' show TestBootstrapBuilder;
 
-DebugTestBuilder debugTestBuilder(_) => const DebugTestBuilder();
-DebugIndexBuilder debugIndexBuilder(_) => const DebugIndexBuilder();
-TestBootstrapBuilder testBootstrapBuilder(_) => TestBootstrapBuilder();
+DebugTestBuilder debugTestBuilder(BuilderOptions _) => const DebugTestBuilder();
+DebugIndexBuilder debugIndexBuilder(BuilderOptions _) =>
+    const DebugIndexBuilder();
+TestBootstrapBuilder testBootstrapBuilder(BuilderOptions _) =>
+    TestBootstrapBuilder();
diff --git a/build_test/pubspec.yaml b/build_test/pubspec.yaml
@@ -1,6 +1,6 @@
 name: build_test
 description: Utilities for writing unit tests of Builders.
-version: 2.2.3
+version: 2.2.4-wip
 repository: https://github.com/dart-lang/build/tree/master/build_test
 resolution: workspace
 
diff --git a/build_web_compilers/CHANGELOG.md b/build_web_compilers/CHANGELOG.md
@@ -1,3 +1,5 @@
+## 4.1.1-wip
+
 ## 4.1.0
 
 - Support package:archive version 4.x.
diff --git a/build_web_compilers/lib/builders.dart b/build_web_compilers/lib/builders.dart
@@ -18,8 +18,9 @@ Builder webEntrypointBuilder(BuilderOptions options) =>
 // Ddc related builders
 Builder ddcMetaModuleBuilder(BuilderOptions options) =>
     MetaModuleBuilder.forOptions(ddcPlatform, options);
-Builder ddcMetaModuleCleanBuilder(_) => MetaModuleCleanBuilder(ddcPlatform);
-Builder ddcModuleBuilder([_]) => ModuleBuilder(ddcPlatform);
+Builder ddcMetaModuleCleanBuilder(BuilderOptions _) =>
+    MetaModuleCleanBuilder(ddcPlatform);
+Builder ddcModuleBuilder(BuilderOptions _) => ModuleBuilder(ddcPlatform);
 
 Builder ddcBuilder(BuilderOptions options) {
   validateOptions(options.config, _supportedOptions, 'build_web_compilers:ddc');
@@ -52,7 +53,7 @@ Builder ddcKernelBuilder(BuilderOptions options) {
       trackUnusedInputs: _readTrackInputsCompilerOption(options));
 }
 
-Builder sdkJsCopyRequirejs(_) => SdkJsCopyBuilder();
+Builder sdkJsCopyRequirejs(BuilderOptions _) => SdkJsCopyBuilder();
 Builder sdkJsCompile(BuilderOptions options) => SdkJsCompileBuilder(
       sdkKernelPath: 'lib/_internal/ddc_platform.dill',
       outputPath: 'lib/src/dev_compiler/dart_sdk.js',
@@ -62,18 +63,20 @@ Builder sdkJsCompile(BuilderOptions options) => SdkJsCompileBuilder(
 // Dart2js related builders
 Builder dart2jsMetaModuleBuilder(BuilderOptions options) =>
     MetaModuleBuilder.forOptions(dart2jsPlatform, options);
-Builder dart2jsMetaModuleCleanBuilder(_) =>
+Builder dart2jsMetaModuleCleanBuilder(BuilderOptions _) =>
     MetaModuleCleanBuilder(dart2jsPlatform);
-Builder dart2jsModuleBuilder([_]) => ModuleBuilder(dart2jsPlatform);
+Builder dart2jsModuleBuilder(BuilderOptions _) =>
+    ModuleBuilder(dart2jsPlatform);
 PostProcessBuilder dart2jsArchiveExtractor(BuilderOptions options) =>
     Dart2JsArchiveExtractor.fromOptions(options);
 
 // Dart2wasm related builders
 Builder dart2wasmMetaModuleBuilder(BuilderOptions options) =>
     MetaModuleBuilder.forOptions(dart2wasmPlatform, options);
-Builder dart2wasmMetaModuleCleanBuilder(_) =>
+Builder dart2wasmMetaModuleCleanBuilder(BuilderOptions _) =>
     MetaModuleCleanBuilder(dart2wasmPlatform);
-Builder dart2wasmModuleBuilder([_]) => ModuleBuilder(dart2wasmPlatform);
+Builder dart2wasmModuleBuilder(BuilderOptions _) =>
+    ModuleBuilder(dart2wasmPlatform);
 
 // General purpose builders
 PostProcessBuilder dartSourceCleanup(BuilderOptions options) =>
diff --git a/build_web_compilers/pubspec.yaml b/build_web_compilers/pubspec.yaml
@@ -1,9 +1,7 @@
 name: build_web_compilers
-version: 4.1.0
+version: 4.1.1-wip
 description: Builder implementations wrapping the dart2js and DDC compilers.
 repository: https://github.com/dart-lang/build/tree/master/build_web_compilers
-# This package can't be part of the workspace because it requires a very recent
-# Dart SDK - see the top-level pubspec for details.
 resolution: workspace
 
 environment:
diff --git a/build_web_compilers/test/dev_compiler_bootstrap_test.dart b/build_web_compilers/test/dev_compiler_bootstrap_test.dart
@@ -165,7 +165,8 @@ Future<void> runPrerequisites(Map<String, Object> assets) async {
   // It is necessary to add a fake asset so that the build_web_compilers
   // package exists.
   var sdkAssets = <String, Object>{'build_web_compilers|fake.txt': ''};
-  await testBuilderAndCollectAssets(sdkJsCopyRequirejs(null), sdkAssets);
+  await testBuilderAndCollectAssets(
+      sdkJsCopyRequirejs(const BuilderOptions({})), sdkAssets);
   await testBuilderAndCollectAssets(
       sdkJsCompile(const BuilderOptions({})), sdkAssets);
   assets.addAll(sdkAssets);
diff --git a/build_web_compilers/tool/copy_builder.dart b/build_web_compilers/tool/copy_builder.dart
@@ -5,7 +5,7 @@
 import 'package:build/build.dart';
 
 /// Factory for the build script.
-Builder copyBuilder(_) => _CopyBuilder();
+Builder copyBuilder(BuilderOptions _) => _CopyBuilder();
 
 /// Copies the [_stackTraceMapperJs] file to [_stackTraceMapperCopyJs].
 class _CopyBuilder extends Builder {

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+## 5.0.11-wip`
	`2`	`+`
`1`	`3`	`## 5.0.10`
`2`	`4`
`3`	`5`	`- Bump the min sdk to 3.6.0.`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+## 2.4.4-wip`
	`2`	`+`
`1`	`3`	`## 2.4.3`
`2`	`4`
`3`	`5`	- Require the latest analyzer, and stop passing the `withNullability`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+## 2.2.4-wip`
	`2`	`+`
`1`	`3`	`## 2.2.3`
`2`	`4`
`3`	`5`	`- Bump the min sdk to 3.6.0.`