Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid #53

Open
HosseinAsadi opened this issue Apr 20, 2021 · 6 comments
Open

invalid #53

HosseinAsadi opened this issue Apr 20, 2021 · 6 comments

Comments

@HosseinAsadi
Copy link

The package does not generate the private key and address correctly at all

check your example into https://iancoleman.io/bip39/ on bitcoin network

@i5hi
Copy link

i5hi commented Apr 28, 2021

We just tested the key generation and derivation yesterday as part of our project and it works correctly. We tested it against Bitcoin-Core and BDK.

Can you provide a specific test case ?

@nycm1989
Copy link

You must to create the address with an a derivation path like "m/44'/1'/0'/0/0"

@pablonlr
Copy link

pablonlr commented Jun 7, 2022

I have the same problem, it doesn't generate the same private keys/addresses as

https://iancoleman.io/bip39/

I have also tried the seed in other HD wallets and it is still not the same keys.

@i5hi
Copy link

i5hi commented Jun 7, 2022

I would only use this library to EXPERIMENT. It's been dead for a while now.

Look into bdk. They have a bdk-ffi for direct native bindings to Kotlin and Swift.

If you want direct compatibility with dart, check out https://github.com/StackmateNetwork/the-stackmate

It currently only supports android but we are in the process of extended it to iOS too.

Just copy /packages/libstackmate/* & /lib/api/interface/libstackmate.dart & /lib/api/libstackmate.dart into your project and add libstackmate to your pubspec.yaml

You can use packages/libstackmate/update-core.sh to get the latest binaries from https://github.com/StackmateNetwork/stackmate-core or build it yourself. This will give you a really powerful descriptor wallet that leverages the awesome bdk wallet api.

Feel free to create issues if on our projects if you need any help. We are actively updating and looking for support.

libstackmate is also being used in a production application: Stackmate Wallet Play Store

@pablonlr
Copy link

pablonlr commented Jun 7, 2022

Thanks, I'm already keeping an eye on it. Is it safe to send the seed or root key via rust bidings?

@i5hi
Copy link

i5hi commented Jun 7, 2022

Thanks, I'm already keeping an eye on it. Is it safe to send the seed or root key via rust bidings?

yes, afaik.

rust cleans up after itself. the point of vulnerability is then the C pointer that dart is left with, which im pretty sure gets handled properly by the dart FFI library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants