Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hamo exported hooks #56

Open
quentinbrohan opened this issue Dec 13, 2024 · 3 comments
Open

Missing hamo exported hooks #56

quentinbrohan opened this issue Dec 13, 2024 · 3 comments

Comments

@quentinbrohan
Copy link

Hell-O, I've noticed while trying to run Storybook locally that it crashes when importing 2 of the @darkroom/engineering/hamo hooks:

  • useLazyState
  • useObjectFit

The error is ignored because of the libs/overwrite.d.ts types, which mark them as existing (commenting the file shows ExtendedDOMRect is missing too in the library).

Changing those 2 lines makes Storybook run with no crash (so would the components on the app), so I suspect the latest hamo release hasn't been triggered. Satus is using the version 0.6.46 whereas the release page shows the latest is 0.6.9 but it's not found on install nor displayed on npmjs.

  • In hooks/use-scroll-trigger, change useLazyState import from @darkroom... to hooks/use-lazy-state (since the file is existing in Satus).
  • in hooks/use-scroll-trigger, change the useObjectFit import from @darkroom... to hooks/use-object-fit, and create a file of the same name with the code from the hamo library directly.
@clementroche
Copy link
Member

Thanks @quentinbrohan, we're a in a middle of a lot of changes. We gonna take care of it. cc @feledori

@feledori
Copy link
Contributor

feledori commented Jan 8, 2025

thanks for pointing this out. yeah, the overwrite.d.ts is just to have the types in satus until we bring the types to the package, where they actually belong.

@clementroche
Copy link
Member

clementroche commented Jan 8, 2025

BTW, it's in progress in Hamo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants