Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper way to modify sieve scripts #5

Open
Smarre opened this issue Sep 28, 2019 · 3 comments · May be fixed by #7
Open

Proper way to modify sieve scripts #5

Smarre opened this issue Sep 28, 2019 · 3 comments · May be fixed by #7

Comments

@Smarre
Copy link

Smarre commented Sep 28, 2019

Hi,

It looks like that actual spam dir is hardcoded in sieve scripts. In some setups, it makes sense to use different spam folder, so the path needs to be changed. I can’t find any proper way to override the existing sieve scripts so that they would not be replaced with updates.

Probably there should be a configuration option to specify additional directory to load configs from (with similar idea with rspamd’s local.d and override.d), which would replace the sieve script in system if the name matches.

Another option would be that actual files can be specified in the config, but I suppose that would be inconvenient if any new files gets added.
@Smarre
Copy link
Author

Smarre commented Sep 28, 2019

Actually it looks like this specific script is fairly trivial to override with sieve_before in 99-antispam_with_sieve.conf. So I guess my use case isn’t valid. That feature may have some merit still though.

@darix
Copy link
Owner

darix commented Sep 30, 2019

This needs support from pigeonhole. in theory one could query the special folder Junk and then use that. then we wouldnt need to hard code the folder path at all but could query the configured value from the dovecot configuration. I was told that it is on the backlog for dovecot but not done yet.

@Smarre
Copy link
Author

Smarre commented Sep 30, 2019

Okay, thanks for digging out this info :)

@darix darix linked a pull request Jun 11, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it easier to configure the paths and sieve script file darix/dovecot-sieve-antispam-rspamd
2 participants
@darix @Smarre