Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Currency in Ledger CLI doesn't connect with credentials #88

Open
darcys22 opened this issue Sep 29, 2020 · 0 comments
Open

Add Currency in Ledger CLI doesn't connect with credentials #88

darcys22 opened this issue Sep 29, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@darcys22
Copy link
Owner

darcys22 commented Sep 29, 2020

Still uses only the insecure method to connect.

When we upgraded the connection methods for GRPC new logic was added to the code to include a check for flags, read the certificate files and then connect using the secure method. Else connect to the GRPC server using the insecure method.

This can be seen in the code within ledger_cli/transaction.go in the “send” function for example.

However in ledger_cli/addcurrency.go the only option is to connect using the insecure method

conn, err := grpc.Dial(address, grpc.WithInsecure())

This section of the code needs to be updated to be in line with the rest of the codebase and allow for secure connections.

@darcys22 darcys22 added the good first issue Good for newcomers label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant