Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link references in Observability tutorial #895

Closed
msfussell opened this issue Jul 31, 2023 · 3 comments
Closed

Fix broken link references in Observability tutorial #895

msfussell opened this issue Jul 31, 2023 · 3 comments
Milestone

Comments

@msfussell
Copy link
Member

In this tutorial https://github.com/dapr/quickstarts/tree/master/tutorials/observability
The build is failing due to broken links. See below.
image

https://docs.dapr.io/developing-applications/building-blocks/observability/tracing-overview/ needs to be replaced with this link
https://docs.dapr.io/operations/monitoring/tracing/

There are two references to fix one at the start and one at the end

@msfussell msfussell added this to the 1.11 milestone Jul 31, 2023
@MregXN
Copy link
Member

MregXN commented Sep 6, 2023

External link validation:
        https://docs.dapr.io/concepts/observability-concept/ Status: 200
        https://docs.dapr.io/operations/observability/tracing/tracing-overview/ Status: 200
        https://opencensus.io/ Status: 200
        https://zipkin.io/ Status: 200
        https://hub.docker.com/r/openzipkin/zipkin/ Status: 200
        https://zipkin.io/zipkin-api/ Status: 200
        https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-deploy/ Status: 200
        https://docs.dapr.io/getting-started/tutorials/configure-state-pubsub/#step-1-create-a-redis-store Status: 200
        http://localhost:19411 Status: Ignored
        https://github.com/dapr/quickstarts/blob/master/tutorials/distributed-calculator/deploy/react-calculator.yaml#L36 Status: 200
        https://github.com/dapr/quickstarts/tree/master/tutorials/distributed-calculator Status: 200
        http://localhost:19411 Status: Ignored
        https://docs.dapr.io/concepts/observability-concept/ Status: 200
        https://docs.dapr.io/operations/observability/tracing/tracing-overview/ Status: 200

This is the log after I run make validate and it seems that the issue you mentioned is not existed. Maybe you could try again with the latest version of dapr/quickstarts.

@MregXN
Copy link
Member

MregXN commented Sep 6, 2023

Sorry I just found the PR #896 of fixing this issue. Maybe we could close this issue directly.

@msfussell
Copy link
Member Author

Yes, this is fixed. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants