Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: update code to more modern version #887

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

batazor
Copy link
Contributor

@batazor batazor commented Jul 3, 2023

Description

  • Replaced the deprecated method with the new recommended method
  • Updated the error handling

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for this contribution and modernizing the golang code .. in all the quickstarts!

@paulyuk
Copy link
Contributor

paulyuk commented Jul 8, 2023

Let's wait for the tests to pass.

@batazor
Copy link
Contributor Author

batazor commented Jul 18, 2023

@paulyuk all good)

@paulyuk paulyuk merged commit 6b258d0 into dapr:master Aug 22, 2023
@paulyuk
Copy link
Contributor

paulyuk commented Aug 22, 2023

@paulyuk all good)

Thank you @batazor - I was away for a bit. This looks great. Merged!

@yaron2 yaron2 added this to the 1.12 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants