Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Conversation http Quickstart #1150

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

rochabr
Copy link
Contributor

@rochabr rochabr commented Jan 28, 2025

Description

Creating Conversation Quickstart for Python - HTTP

Issue reference

Please reference the issue this PR will close: #1108

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@rochabr rochabr requested review from a team as code owners January 28, 2025 19:30
@rochabr
Copy link
Contributor Author

rochabr commented Jan 28, 2025

@alicejgibbons

Copy link

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for the crypto test fix to get merged first, so we can see this test passing.

@marcduiker
Copy link
Contributor

Suggested two small changes to ensure all multi-app run files always start with the appID key in the apps array. Related to PR #1152.

rochabr and others added 2 commits January 29, 2025 08:54
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Copy link

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to merge after Elena's PR: #1148

@msfussell msfussell merged commit 7e0433e into dapr:release-1.15 Jan 30, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants