Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java Quickstarters to Java 17 and Springboot 3.x #1042

Closed
amardeep2006 opened this issue Jun 28, 2024 · 2 comments
Closed

Upgrade Java Quickstarters to Java 17 and Springboot 3.x #1042

amardeep2006 opened this issue Jun 28, 2024 · 2 comments

Comments

@amardeep2006
Copy link
Contributor

amardeep2006 commented Jun 28, 2024

Describe the feature

I noticed that Java examples can be improved by making following changes:

  1. Use Java 17 as baseline in ReadME
  2. Upgrade example to use Springboot 3.x.x
  3. Use Java records instead of Lombok . One less dependency to manage. (In future)
  4. Start adding test cases (gradually) .

Please share your feedback on this. I am interested in sending PR if you are good with these suggestions.

@amardeep2006
Copy link
Contributor Author

amardeep2006 commented Jun 29, 2024

I have raised a PR #1044

  1. Java Readme now correctly asks to use Java 17 as code base already needed Java17
  2. Upgraded springboot t 3.3.1
  3. Bumped up other dependencies as well.

I have not replaced Lombok . Will raise separate PR if needed.

@msfussell
Copy link
Member

Closing this issue. @amardeep2006 THANK YOU for this amazing contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants