Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflows] Rename callSubWorkflow to callChildWorkflow #1155

Closed
olitomlinson opened this issue Oct 29, 2024 · 1 comment · Fixed by #1168
Closed

[Workflows] Rename callSubWorkflow to callChildWorkflow #1155

olitomlinson opened this issue Oct 29, 2024 · 1 comment · Fixed by #1168
Labels
kind/enhancement New feature or request
Milestone

Comments

@olitomlinson
Copy link

olitomlinson commented Oct 29, 2024

The Java SDK uses the method name callSubWorkflow rather than callChildWorkflow in the workflow context

The Dapr documentation refers to child workflows , so I would recommend that the Java SDK change the method name to callChildWorkflow for consistency.

@salaboy
Copy link
Contributor

salaboy commented Dec 4, 2024

@olitomlinson ok.. PR created.. I will follow the tests to see if I am missing something.
@artursouza do you know if we need to deprecate the old methods? Do you know how to create a release note for this change? It is a simple replace to upgrade to this new signature.

@artursouza artursouza added this to the v1.14 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants