-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Maven Profiles #1120
Merged
Merged
Adding Maven Profiles #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@salaboy @artursouza @cicoyle this is a small "quality of life" improvement PR. Please let me know if this looks good and if I should update any of the developer docs. Thank you! 🙇 |
artursouza
approved these changes
Sep 7, 2024
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
artur-ciocanu
force-pushed
the
gh-1119
branch
from
September 7, 2024 09:16
ffbd436
to
b382505
Compare
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Adding Maven Profiles Signed-off-by: Artur Ciocanu <[email protected]> * Simplify profiles setup Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Adding Maven Profiles Signed-off-by: Artur Ciocanu <[email protected]> * Simplify profiles setup Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Adding Maven Profiles Signed-off-by: Artur Ciocanu <[email protected]> * Simplify profiles setup Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Adding Maven Profiles Signed-off-by: Artur Ciocanu <[email protected]> * Simplify profiles setup Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Oct 4, 2024
* Adding Maven Profiles Signed-off-by: Artur Ciocanu <[email protected]> * Simplify profiles setup Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Maven Profiles so we can improve developer experience when developing the Dapr Java SDK. This should allow us to load all the code in a single IDE instance while allowing us the flexibility to run integration test modules separately from the main code.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1119.
It is also somewhat related to #1075.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: