Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Redis transactions limitations #3635

Closed
2 tasks
hhunter-ms opened this issue Jul 25, 2023 · 2 comments · Fixed by #3848
Closed
2 tasks

Docs for Redis transactions limitations #3635

hhunter-ms opened this issue Jul 25, 2023 · 2 comments · Fixed by #3848
Assignees

Comments

@hhunter-ms
Copy link
Collaborator

hhunter-ms commented Jul 25, 2023

@hhunter-ms hhunter-ms added this to the 1.12 milestone Jul 25, 2023
@hhunter-ms hhunter-ms self-assigned this Jul 25, 2023
@yaron2
Copy link
Member

yaron2 commented Jul 25, 2023

@hhunter-ms we should definitely not document that Redis shouldn't be used as a state store. On the contrary, it's one of the most stable, tested and widely used state stores. What needs to be documented is that it's not a fit for transactions unless you can accept the limitations imposed by Redis transactions (documented here https://redis.io/docs/interact/transactions/#what-about-rollbacks).

In the future we might deprecate the transactions capability on Redis but that decision hasn't been made yet.

@hhunter-ms
Copy link
Collaborator Author

@hhunter-ms we should definitely not document that Redis shouldn't be used as a state store. On the contrary, it's one of the most stable, tested and widely used state stores. What needs to be documented is that it's not a fit for transactions unless you can accept the limitations imposed by Redis transactions (documented here https://redis.io/docs/interact/transactions/#what-about-rollbacks).

ah thanks for the clarification - I overheard this in the sync earlier but didn't totally catch the context

@hhunter-ms hhunter-ms changed the title Update docs in favor of SQLite as default state store Docs for Redis transactions limitations Sep 8, 2023
@hhunter-ms hhunter-ms removed this from the 1.12 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants