-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the CLI install script release source #1454
Comments
@dapr/maintainers-cli - thoughts on the proposed solution? |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions. |
/keep-alive |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions. |
Expected Behavior
Release versions should be retrieved successfully.
Actual Behavior
Users may hit the 60 requests per hour limit (per IP) when calling the github api unauthenticated.
Steps to Reproduce the Problem
Call any github api endpoint 60 times, run the install script which fails to find a release version for the CLI and the invalid version is not handled.
Proposed Solution
A "version" branch is set up and maintained by a workflow which is triggered by dispatch (primarily intended for the release job to trigger this workflow on completion).
The version branch will contain a docs folder with a single file containing the latest version tag for the CLI and will be served by gh-pages or an azure static site (with preference for gh-pages).
The install scripts will no longer hit the API for the latest tag.
Release Note
RELEASE NOTE: FIX Dapr CLI install/update release version retrieval
The text was updated successfully, but these errors were encountered: